Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Add optional manager transpilation. #17

Merged
merged 3 commits into from
Jun 18, 2019
Merged

[TS] Add optional manager transpilation. #17

merged 3 commits into from
Jun 18, 2019

Conversation

mathieutu
Copy link
Contributor

@mathieutu mathieutu commented Jun 17, 2019 •
edited
Loading

Hi,
this fixes #16.

I've also fixed the outdated typings.

Thanks for the amazing work.
Matt'

@mathieutu mathieutu mentioned this pull request Jun 17, 2019
Closed
@shilman shilman requested a review from igor-dv June 17, 2019 23:23
shilman
shilman requested changes Jun 17, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathieutu This is a great change. 🥇 Any chance you can add transpileManager to README.md?

@mathieutu
Copy link
Contributor Author

Here we go @shilman!

shilman
shilman approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏 Will give @igor-dv a chance to review also

igor-dv
igor-dv approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shilman shilman merged commit 8902a24 into storybookjs:master Jun 18, 2019
@shilman
Copy link
Member

shilman commented Jun 18, 2019

Published as 1.1.0

@mathieutu
Copy link
Contributor Author

Thanks for your so quick action!

@ralexandr ralexandr mentioned this pull request Feb 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv igor-dv approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TS] Handle Addons
3 participants
@mathieutu @shilman @igor-dv