Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for storybook 6.4/6.5, CSF3 and HMR fix #384

Merged
merged 28 commits into from Nov 2, 2022
Merged

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Oct 13, 2022

Issue:

This is the initial attempts at getting the new story store working in react native storybook

What I did

  • 6.5+ support in rn storybook
  • re-uses preview web from storybook core by monkey patching the render functions and url store
  • introduces a small document polyfill to stop document.location from crashing in the preview web constructor

How to test

yarn install
cd app/native
yarn prepare
cd ../../examples/native`
yarn web 

Early build released at 6.0.1-canary.1

Example project with a early build
https://github.com/dannyhw/react-native-storybook-6.5-example

With the introduction of this patch in 6.5 we should be able to remove the document polyfill
storybookjs/storybook#19623

also resolves #30

@dannyhw dannyhw self-assigned this Oct 13, 2022
@dannyhw dannyhw changed the title 6.5 [WIP] very experimental so far 6.5 [WIP] Oct 23, 2022
@dannyhw dannyhw marked this pull request as ready for review October 30, 2022 12:09
@dannyhw dannyhw changed the title 6.5 [WIP] feat: support for 6.5 story store Oct 30, 2022
@dannyhw dannyhw changed the title feat: support for 6.5 story store feat: support for storybook 6.4/6.5 new story store and CSF3 Oct 30, 2022
@dannyhw dannyhw changed the title feat: support for storybook 6.4/6.5 new story store and CSF3 feat: support for storybook 6.4/6.5, CSF3 and HMR fix Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants