Skip to content

Commit

Permalink
ADD some better upgrade messages
Browse files Browse the repository at this point in the history
  • Loading branch information
Tom Coleman committed Mar 4, 2019
1 parent c2d55a4 commit 6dfa51a
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 11 deletions.
1 change: 0 additions & 1 deletion addons/viewport/preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ exports.configureViewport = preview.configureViewport;
exports.DEFAULT_VIEWPORT = preview.DEFAULT_VIEWPORT;
exports.INITIAL_VIEWPORTS = preview.INITIAL_VIEWPORTS;
exports.withViewport = preview.withViewport;
exports.Viewport = preview.Viewport;
1 change: 1 addition & 0 deletions addons/viewport/src/Tool.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const getState = memoize(10)((props, state, change) => {
const parameters = data && data.parameters && data.parameters[PARAM_KEY];

if (typeof parameters !== 'object') {
// eslint-disable-next-line no-console
console.warn(
'The viewport parameter must be an object with keys `viewports` and `defaultViewport`'
);
Expand Down
4 changes: 2 additions & 2 deletions addons/viewport/src/legacy_preview/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import deprecate from 'util-deprecate';

export { INITIAL_VIEWPORTS, DEFAULT_VIEWPORT } from '../defaults';
export { default as withViewport, Viewport } from './withViewport';
export { default as withViewport } from './withViewport';

export const configureViewport = deprecate(() => {},
'usage is deprecated, use .addParameters({ viewport }) instead');
'configureViewport is no longer supported, use .addParameters({ viewport }) instead');
10 changes: 2 additions & 8 deletions addons/viewport/src/legacy_preview/withViewport.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,11 @@ import deprecate from 'util-deprecate';

const withViewport = makeDecorator({
name: 'withViewport',
parameterName: 'viewports',
allowDeprecatedUsage: true,
parameterName: 'viewport',
wrapper: deprecate(
(getStory, context) => getStory(context),
'usage is deprecated, use .addParameters({ viewport }) instead'
'withViewport is no longer supported, use .addParameters({ viewport }) instead'
),
});

export default withViewport;

export const Viewport = deprecate(
({ children }) => children,
`<Viewport> usage is deprecated, use .addParameters({ viewport }) instead`
);

0 comments on commit 6dfa51a

Please sign in to comment.