Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tracking #1003

Closed
phillipj opened this issue May 8, 2017 · 4 comments
Closed

Remove tracking #1003

phillipj opened this issue May 8, 2017 · 4 comments
Assignees
Labels
help wanted maintenance User-facing maintenance tasks

Comments

@phillipj
Copy link

phillipj commented May 8, 2017

Hi,

first of all fantastic project, I'm really enjoying it πŸ‘

I got curious as to why tracking was needed, so I tried to visit the URL displayed when I start storybook:

➜ npm run storybook

> clearing-ui@0.1.0 storybook /my/cra/project
> start-storybook -p 9009 -s public

@kadira/storybook v2.35.3

=> Loading static files from: /my/cra/project/public .
=> Using default webpack setup based on "Create React App".
=> Loading custom webpack config (full-control mode).

React Storybook started on => http://localhost:9009/

 We will collect some anonymous usage stats of how you use storybook.
 See why?: https://getstorybook.io/tracking

But https://getstorybook.io/tracking ends in a 404 page sadly 😞

I'm more than willing to open a PR fixing it, if I only knew the correctly URL?

@tmeasday
Copy link
Member

I'm not sure we have control of the reporting end point (we should figure that out @ndelangen?), but I think that URL went here: https://stats.getstorybook.io/

I guess we should update it to that in the meantime.

@ndelangen
Copy link
Member

If someone wants to create a PR completely removing the tracking, I'm happy to merge that.

We'll gain insights by asking users.

@ndelangen ndelangen changed the title Update tracking info URL Remove tracking May 15, 2017
@ndelangen ndelangen added maintenance User-facing maintenance tasks help wanted ready and removed bug labels May 15, 2017
@tmeasday tmeasday assigned tmeasday and shilman and unassigned tmeasday and shilman May 16, 2017
@phillipj
Copy link
Author

Thought I'd help out removing the tracking related code, but it doesn't seem to be included in the v3 source.

Therefore closing this as it's not a concern anymore.

Oh and thanks for your work getting v3 out, great work! πŸ‘

@arunoda arunoda removed the ready label May 30, 2017
@ndelangen
Copy link
Member

Correct I already removed it, thanks for checking and closing issues πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted maintenance User-facing maintenance tasks
Projects
None yet
Development

No branches or pull requests

5 participants