Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Preview Toolbar has scrollbar #10207

Closed
stefanprobst opened this issue Mar 24, 2020 · 7 comments
Closed

[components] Preview Toolbar has scrollbar #10207

stefanprobst opened this issue Mar 24, 2020 · 7 comments

Comments

@stefanprobst
Copy link
Contributor

Describe the bug
The DocsPage Preview component Toolbar has a scrollbar when the IconButton's box-sizing is not reset to border-box somewhere else.

Toolbar has height 40, and IconButton has height: 40 + 3 border

Screenshots
preview-header

@stale
Copy link

stale bot commented Apr 14, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 14, 2020
@stale
Copy link

stale bot commented May 15, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed May 15, 2020
@shilman shilman reopened this May 15, 2020
@stale stale bot removed the inactive label May 15, 2020
@stale
Copy link

stale bot commented Jun 5, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jun 5, 2020
ndelangen added a commit that referenced this issue Jun 16, 2020
Core: Add global box-sizing setting. Fixes #10207
@shilman
Copy link
Member

shilman commented Jun 16, 2020

Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.30 containing PR #11055 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

@stevenpetryk
Copy link

stevenpetryk commented Dec 13, 2021

That PR did not fix this issue—it's still present in the docs view in 6.4.9. Had to add this CSS to preview-head.html to fix:

.sbdocs .os-content a {
  margin-top: 0 !important;
  height: unset !important;
}

@shilman shilman reopened this Dec 13, 2021
@stale stale bot removed the inactive label Dec 13, 2021
@ndelangen
Copy link
Member

@matheo can you confirm the issue is still present, and if so investigate an improved fix? 🙏

@shilman
Copy link
Member

shilman commented Jun 8, 2023

We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:

@shilman shilman closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants