-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storybook/angular] Incompatible dependency with TypeScript 4.0 #12859
Comments
Does TS4.0 work with older versions of angular? Can we just change the version specifier to be |
@shilman Current stable version of Angular (v10.1) supports TS3.9 or 4.0. And v11.0 only supports TS4.0. I think, Storybook only needs to have peer dependency range for Angular family. It can restrict minimum Angular version instead of minimum TypeScript version. If developers use |
|
I see, thank you for explaining. So, as you said I think |
Do you mind making a small PR to fix it? |
…port Angula7 With the release of Angular v11-rc.0, TypeScript 4.0 must be supported in order to `ng update`. Updating the peerDep to `>=3.4.0` allows `@storybook/angular` to be compatible back to Angular 6. This resolves issue storybookjs#12859
`@storybook/angular` should be compatible with Angular 11 which requires TypeScript 4.0 This resolves storybookjs#12859 by supporting any version above Angular 6 through the latest RC
`@storybook/angular` should be compatible with Angular 11 which requires TypeScript 4.0 This resolves storybookjs#12859 by supporting any version above Angular 6 through the latest RC
Yippee!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.0-alpha.28 containing PR #12866 that references this issue. Upgrade today to the
|
Describe the bug
In the package.json of
@storybook/angular
,typescript
peer dependency version is pinned as^3.4.0
so it works until Angular v10 and TS3.9.Since Angualr v11 (RC has began), TS4.0 is only supported.
ng update
command try to update TypeScript to 4.0 but version conflict happens.In fact, TypeScript is not following Semver convention. Pinning version with
^
doesn't make sense.Expected behavior
Angular (
@angular-devkit/build-angular
) has its own peer dependency for TypeScript so I think Storybook don't have to depend on it by itself again.The text was updated successfully, but these errors were encountered: