Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive conflicts after upgrading React-Native to 0.46 #1454

Closed
xareelee opened this issue Jul 12, 2017 · 4 comments
Closed

Massive conflicts after upgrading React-Native to 0.46 #1454

xareelee opened this issue Jul 12, 2017 · 4 comments

Comments

@xareelee
Copy link

xareelee commented Jul 12, 2017

I just upgrade React-Native from 0.45.1 to 0.46.1. After upgrading, the stroyshots cases failed massively. All <View/>, <Text/>, <Image/> are replaced with </> components in the result of the jest.

Need I do something to fix this?

Anyone encountered this?

A sample of the jest failed results with storyshots is:

screen shot 2017-07-13 at 09 32 33

I have hundred tests failed with the same problem.

@shilman
Copy link
Member

shilman commented Jul 12, 2017

Yowza! @xareelee there's a PR that might help: #1424

Maybe try that out in the short term?

If not, one of us will dig into it soon.

@xareelee
Copy link
Author

xareelee commented Jul 13, 2017

@shilman Thanks for your reply. I'm not sure how to try the commit. I use 3 libs from storybook:

  "devDependencies": {
    "@storybook/addon-knobs": "^3.1.8",
    "@storybook/addon-storyshots": "^3.1.8",
    "@storybook/react-native": "^3.1.8",
    ...
  }

Do I need to remove them in the package.json, and use yarn add --dev <git remote url>#<branch/commit/tag> to install a specific commit?

I have no idea how to find the commit url in the pull request page #1424. Can you help me out?

@xareelee
Copy link
Author

@shilman Don't bother. 😄

This issue has been resolved by upgrading React-Native from 0.46.1 to 0.46.2.

@shilman
Copy link
Member

shilman commented Jul 13, 2017

Glad to hear you fixed it and thanks for posting the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants