Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React runtime automatic breaks MDX #14584

Closed
fcisio opened this issue Apr 13, 2021 · 6 comments
Closed

React runtime automatic breaks MDX #14584

fcisio opened this issue Apr 13, 2021 · 6 comments

Comments

@fcisio
Copy link

fcisio commented Apr 13, 2021

Describe the bug
Using React runtime automatic breaks MDX stories.

 Overall the MDX syntax is really buggy on the latest releases.

Some work needs to be done on MDX, for it to remain a viable syntax to use.

To Reproduce
Steps to reproduce the behavior:

  1. Enable automatic runtime
  2. Write a MDX story

Expected behavior
MDX should still work with runtime automatic

ScreenShot 2021-04-13 at 12 15 48 PM

System
broke on all storybook versions

@shilman
Copy link
Member

shilman commented Apr 14, 2021

Do you have a repro repo you can share?

@fcisio
Copy link
Author

fcisio commented Apr 14, 2021

I wasn't able to reproduce the error with Title, Description or @storybook/components/html

But I did reproduce two things (uncomment to test):

  • MDX argTypes breaking the stories
  • Runtime importSource breaking MDX

The importSource is set to React, which is redundant, but it is to illustrate the issue. The issue would happen with anything else, ex: Emotion JS

See Repro

@fcisio
Copy link
Author

fcisio commented Apr 20, 2021

Any progress on this?
Right now, I'm resorting to removing my MDX docs until this is supported.

From what I found, MDX just doesn't support automatic runtime yet.

I did see this workaround, which could work until it is supported on their end.

Thanks

@ndelangen
Copy link
Member

@shilman I suspect this will be fixed in 7.0 with the MDX upgrade and changes we made.

@github-actions
Copy link
Contributor

Hi there! Thank you for opening this issue, but it has been marked as stale because we need more information to move forward. Could you please provide us with the requested reproduction or additional information that could help us better understand the problem? We'd love to resolve this issue, but we can't do it without your help!

@github-actions github-actions bot added the Stale label Sep 20, 2023
@github-actions
Copy link
Contributor

I'm afraid we need to close this issue for now, since we can't take any action without the requested reproduction or additional information. But please don't hesitate to open a new issue if the problem persists – we're always happy to help. Thanks so much for your understanding.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants