Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show parse errors for numbers and objects; style range input #14972

Closed
1 of 2 tasks
tmeasday opened this issue May 18, 2021 · 3 comments
Closed
1 of 2 tasks

Show parse errors for numbers and objects; style range input #14972

tmeasday opened this issue May 18, 2021 · 3 comments

Comments

@tmeasday
Copy link
Member

tmeasday commented May 18, 2021

Following on from #14579 -- some UI changes @domyen wanted to make that aren't crucial to the core feature (so we won't hold up merging).

  • Show errors (not just red borders) on invalid inputs for Number and Object.
  • Style the Range input w/ green bar.
@domyen
Copy link
Member

domyen commented May 29, 2021

✅ Styled the range input in this commit 6d61470

I need some help with printing the error for Number and Object in the relevant stories. I can get an error to render, but only after I change the input value.

For example: I see this
image

But not when I initially navigate to the Number:mistyped or Number: null story. Same with the Object control.

@shilman
Copy link
Member

shilman commented Jun 6, 2021

Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.3.0-beta.14 containing PR #14973 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@tmeasday
Copy link
Member Author

tmeasday commented Jun 7, 2021

Somehow I missed this comment @domyen. Let's sort of out the input errors in 6.4, I guess: #15158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants