Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls: Style undefined range slider different to filled one #14973

Merged
merged 4 commits into from
Jun 6, 2021
Merged

Controls: Style undefined range slider different to filled one #14973

merged 4 commits into from
Jun 6, 2021

Conversation

tmeasday
Copy link
Member

Issue: #14972

@tmeasday tmeasday requested a review from domyen May 18, 2021 05:20
@tmeasday tmeasday requested a review from ndelangen as a code owner May 18, 2021 05:20
@tmeasday tmeasday changed the base branch from next to 14579-undefined-inputs May 18, 2021 05:20
@nx-cloud
Copy link

nx-cloud bot commented May 18, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 6becc63. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Base automatically changed from 14579-undefined-inputs to next May 18, 2021 06:54
@tmeasday tmeasday marked this pull request as draft May 19, 2021 00:23
@tmeasday tmeasday changed the title Add error information to inputs Style undefined progress different to filled one Jun 1, 2021
@tmeasday tmeasday force-pushed the 14972-undefined-inputs-errors branch from 6d61470 to 75512a5 Compare June 1, 2021 01:12
@tmeasday tmeasday marked this pull request as ready for review June 1, 2021 01:13
shilman
shilman requested changes Jun 1, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core-server/prebuilt files should not be checked in

@tmeasday tmeasday force-pushed the 14972-undefined-inputs-errors branch from 377c511 to 6becc63 Compare June 6, 2021 10:10
@tmeasday
Copy link
Member Author

tmeasday commented Jun 6, 2021

@shilman done

@shilman shilman changed the title Style undefined progress different to filled one Controls: Style undefined range slider different to filled one Jun 6, 2021
shilman
shilman approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@shilman shilman merged commit a41fdaf into next Jun 6, 2021
@shilman shilman deleted the 14972-undefined-inputs-errors branch June 6, 2021 13:38
This was referenced Jun 6, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@domyen domyen Awaiting requested review from domyen

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees

@domyen domyen

Labels
addon: controls feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmeasday @shilman @domyen