3.2-alpha: HMR broken

[shilman]

why

Expanding on @usulpro 's comment. Do the following in branch release/3.2 vs. master (3.1.x):

yarn bootstrap
cd examples/cra-kitchen-sink
yarn storybook

Then select one of the Button stories (not the Welcome story).
In a separate window, edit the you're looking at (e.g. change the button text).

Expected behavior (3.1.x):

• The button text will update.

Actual behavior (3.2-alpha):

• The page will reload and the Welcome story will show.

Note: when switching between branches, you may need to clean out your node_modules. You can do this by running:

git clean -fdx

This deletes all files that are not part of the git repo, so be careful if you have files lying around!

what

• diagnose the problem
• fix it! 😁

[igor-dv]

Until now it was optional..
Don't we want this kind of checking ?

[ndelangen]

It should remain optional

[igor-dv]

Not providing the module breaks the HMR. But it should remain optional.. I am confused 😕

[shilman]

@ndelangen @igor-dv why optional? And if we want to keep it optional, can we at least print out a warning? Seems like a lot of people are getting bit by this, including us in our sample code!

[ndelangen]

Right, so a single warning into the terminal and console sound fair to me, yes!

Not providing the module breaks the HMR. But it should remain optional.. I am confused 😕

Providing the module enables HMR. If you don't provide the module HMR is not enabled, for whatever reason the users is choosing to.
Now if a lot of users are missing this, a reminder-warning is definitely in order.

[ndelangen]

Is this something you want to do @igor-dv ?

[igor-dv]

Yeah, I'll do it by the end of the week

[ndelangen]

Cool, will close this then, will be released soon!