-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect search in URL #16287
Labels
Comments
If I may, I'm not sure that's a search feature per se, but a filter, used to filter the stories name (or docs pages name) |
Happy to pick this one up 👍 Could I be assigned? |
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Oct 29, 2021
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Oct 29, 2021
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Oct 29, 2021
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Oct 29, 2021
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Oct 30, 2021
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Jan 17, 2022
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Jan 18, 2022
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Jan 18, 2022
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Jan 18, 2022
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Feb 16, 2023
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Feb 16, 2023
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Mar 19, 2023
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Mar 19, 2023
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Mar 19, 2023
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Mar 19, 2023
jh3y
added a commit
to jh3y/storybook
that referenced
this issue
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe
The current search isn't interactable:
Enabling this functionality would be a nice UX improvement
Describe the solution you'd like
Set search input to URL. When users type some search query - reflect it in the URL. The intermediate search query state most likely shouldn't affect the history state, or should it?
On page load search param should be checked and apply search if present
Describe alternatives you've considered
N/A
Are you able to assist to bring the feature to reality?
no
Additional context
![image](https://user-images.githubusercontent.com/9091857/136582562-b388099a-2b54-41b9-86d9-dd3f97f2e455.png)
Current URL:
Suggested URL:
![image](https://user-images.githubusercontent.com/9091857/136582365-04c12393-02e9-4fd8-b478-f397b61ddd10.png)
The text was updated successfully, but these errors were encountered: