Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect search in URL #16287

Open
Klemensas opened this issue Oct 8, 2021 · 2 comments
Open

Reflect search in URL #16287

Klemensas opened this issue Oct 8, 2021 · 2 comments

Comments

@Klemensas
Copy link

Klemensas commented Oct 8, 2021

Is your feature request related to a problem? Please describe

The current search isn't interactable:

  • you can't share the search state with anyone
  • you can't set up a browser search engine for it

Enabling this functionality would be a nice UX improvement

Describe the solution you'd like

Set search input to URL. When users type some search query - reflect it in the URL. The intermediate search query state most likely shouldn't affect the history state, or should it?
On page load search param should be checked and apply search if present

Describe alternatives you've considered

N/A

Are you able to assist to bring the feature to reality?
no

Additional context
Current URL:
image

Suggested URL:
image

@frassinier
Copy link
Contributor

frassinier commented Oct 16, 2021

If I may, I'm not sure that's a search feature per se, but a filter, used to filter the stories name (or docs pages name)

@jh3y
Copy link
Contributor

jh3y commented Oct 18, 2021

Happy to pick this one up 👍 Could I be assigned?

jh3y added a commit to jh3y/storybook that referenced this issue Oct 29, 2021
jh3y added a commit to jh3y/storybook that referenced this issue Oct 29, 2021
jh3y added a commit to jh3y/storybook that referenced this issue Oct 29, 2021
jh3y added a commit to jh3y/storybook that referenced this issue Oct 29, 2021
jh3y added a commit to jh3y/storybook that referenced this issue Oct 30, 2021
jh3y added a commit to jh3y/storybook that referenced this issue Jan 17, 2022
jh3y added a commit to jh3y/storybook that referenced this issue Jan 18, 2022
jh3y added a commit to jh3y/storybook that referenced this issue Jan 18, 2022
jh3y added a commit to jh3y/storybook that referenced this issue Jan 18, 2022
jh3y added a commit to jh3y/storybook that referenced this issue Feb 16, 2023
jh3y added a commit to jh3y/storybook that referenced this issue Feb 16, 2023
jh3y added a commit to jh3y/storybook that referenced this issue Mar 19, 2023
jh3y added a commit to jh3y/storybook that referenced this issue Mar 19, 2023
jh3y added a commit to jh3y/storybook that referenced this issue Mar 19, 2023
jh3y added a commit to jh3y/storybook that referenced this issue Mar 19, 2023
jh3y added a commit to jh3y/storybook that referenced this issue Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

4 participants