Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown option: base.cacheDirectory #1709

Closed
satazor opened this issue Aug 22, 2017 · 7 comments
Closed

Unknown option: base.cacheDirectory #1709

satazor opened this issue Aug 22, 2017 · 7 comments

Comments

@satazor
Copy link
Contributor

satazor commented Aug 22, 2017

I was trying the new 3.2.6-alpha.0 release but it has an error when used with storyshots because of https://github.com/storybooks/storybook/blame/master/app/react/src/server/config/babel.js#L6 which was recently added.

We must omit that in https://github.com/storybooks/storybook/blob/master/addons/storyshots/src/index.js#L41 and probably other places.

//cc @ndelangen

@ndelangen
Copy link
Member

How do I test this?

@ndelangen
Copy link
Member

Can you help me determine if this change fixes the problem?

ndelangen added a commit that referenced this issue Aug 22, 2017
@satazor
Copy link
Contributor Author

satazor commented Aug 23, 2017

Yep I will test it right now.

@satazor
Copy link
Contributor Author

satazor commented Aug 23, 2017

@ndelangen is does work, but shouldn't you apply the same fix to the react app?

@ndelangen
Copy link
Member

ndelangen commented Aug 23, 2017

Thanks for validating!

@ndelangen is does work, but shouldn't you apply the same fix to the react app?

It was already there..

@satazor
Copy link
Contributor Author

satazor commented Aug 23, 2017

@ndelangen Could we have a patch release with the fix? I'm kind of blocked because I need the 3.2.6 because of #1554, but at the same time I can't use it because of this bug.

@shilman
Copy link
Member

shilman commented Aug 23, 2017

@satazor https://github.com/storybooks/storybook/releases/tag/v3.2.7 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants