Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict mode not applied for addon-docs #17880

Closed
flippidippi opened this issue Apr 4, 2022 · 2 comments
Closed

Strict mode not applied for addon-docs #17880

flippidippi opened this issue Apr 4, 2022 · 2 comments
Labels

Comments

@flippidippi
Copy link

flippidippi commented Apr 4, 2022

Describe the bug
When specifying react strictMode, it seems like this isn't being applied to inline stories in doc pages.

To Reproduce

System

Environment Info:

  System:
    OS: Linux 5.10 Ubuntu 20.04.3 LTS (Focal Fossa)
    CPU: (16) x64 Intel(R) Core(TM) i7-10875H CPU @ 2.30GHz
  Binaries:
    Node: 16.6.2 - ~/.nvm/versions/node/v16.6.2/bin/node
    npm: 8.1.0 - ~/.nvm/versions/node/v16.6.2/bin/npm

Additional context
Strict mode is NOT enabled in dev on the "Docs" tab.
image

Strict mode IS enabled in dev on the "Canvas" tab.
image

@m7kvqbe1
Copy link

Also experiencing problems with this.

m7kvqbe1 added a commit to Royal-Navy/design-system that referenced this issue Apr 27, 2022
Disabling by default for now because `focus-trap-react` is throwing StrictMode errors:

focus-trap/focus-trap-react#77

Also worth nothing that currently StrictMode does not work in the Docs tab (only Canvas):

storybookjs/storybook#17880
m7kvqbe1 added a commit to Royal-Navy/design-system that referenced this issue Apr 27, 2022
Disabling by default for now because `focus-trap-react` is throwing StrictMode errors:

focus-trap/focus-trap-react#77

Also worth nothing that currently StrictMode does not work in the Docs tab (only Canvas):

storybookjs/storybook#17880
@shilman
Copy link
Member

shilman commented Jun 8, 2023

We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:

@shilman shilman closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants