Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comments addon? #2180

Closed
danielduan opened this issue Oct 29, 2017 · 0 comments
Closed

Remove comments addon? #2180

danielduan opened this issue Oct 29, 2017 · 0 comments
Assignees
@danielduan
Labels
addon: comments cleanup Minor cleanup style change that won't show up in release changelog discussion
Milestone
v3.3.0

Comments

@danielduan
Copy link
Member

As far as I know, this thing never worked in v3.

Let's delete it for 3.3?
@danielduan danielduan added addon: events cleanup Minor cleanup style change that won't show up in release changelog addon: comments discussion and removed addon: events labels Oct 29, 2017
@danielduan danielduan added this to the v3.3.0 milestone Oct 29, 2017
@danielduan danielduan self-assigned this Oct 31, 2017
danielduan added a commit that referenced this issue Oct 31, 2017
@danielduan
#2180 removing comments from codebase
2565ed5
danielduan added a commit that referenced this issue Oct 31, 2017
@danielduan
#2180 removing addon comments from codebase
469cf1a
@danielduan danielduan mentioned this issue Oct 31, 2017
Merged
Hypnosphi added a commit that referenced this issue Nov 1, 2017
@Hypnosphi
Merge pull request #2189 from storybooks/dd/remove-comments
1904c54 
#2180 removing addon comments from codebase
@dependencies dependencies bot mentioned this issue Mar 16, 2018
Merged
@dependabot-preview dependabot-preview bot mentioned this issue May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielduan danielduan

Labels
addon: comments cleanup Minor cleanup style change that won't show up in release changelog discussion
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
1 participant
@danielduan