Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2180 removing addon comments from codebase #2189

Merged
merged 7 commits into from
Nov 1, 2017

Conversation

danielduan
Copy link
Member

@danielduan danielduan commented Oct 31, 2017

Issue:

#2180 Comments addon to my knowledge hasn't worked since we upgraded to 3.0 and the components it needs such as database are deprecated. We should deprecate this as well.

There's already a copy of it inside our storybook-eol org and I don't think there has been any changes except version number bumps and eslint so I'm just going to leave it as is.

What I did

How to test

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@danielduan danielduan requested review from shilman, ndelangen and a team October 31, 2017 03:16
@danielduan danielduan added cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks labels Oct 31, 2017
@danielduan danielduan added this to the v3.3.0 milestone Oct 31, 2017
@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (release/3.3@b5546af). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.3    #2189   +/-   ##
==============================================
  Coverage               ?   21.98%           
==============================================
  Files                  ?      338           
  Lines                  ?     6700           
  Branches               ?      903           
==============================================
  Hits                   ?     1473           
  Misses                 ?     4528           
  Partials               ?      699

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5546af...64b5774. Read the comment docs.

@Hypnosphi Hypnosphi self-assigned this Nov 1, 2017
@Hypnosphi Hypnosphi merged commit 1904c54 into release/3.3 Nov 1, 2017
@Hypnosphi Hypnosphi deleted the dd/remove-comments branch November 1, 2017 03:04
@shilman shilman mentioned this pull request Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants