Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Storybook asks to send Crash report on all errors #22510

Closed
fireflysemantics opened this issue May 10, 2023 · 11 comments · Fixed by #28433
Closed

[Bug]: Storybook asks to send Crash report on all errors #22510

fireflysemantics opened this issue May 10, 2023 · 11 comments · Fixed by #28433

Comments

@fireflysemantics
Copy link

Describe the bug

When there's an error and we hit ctrl c to fix it and restart, storybook still asks if we want to send a crash report so we have to hit ctrl c again ... It would be nice if it only asked about crash reports when it crashes outside of normal errors:

✖ Would you like to help improve Storybook by sending anonymous crash reports? … yes
^C

To Reproduce

No response

System

Angular 15

Additional context

No response

@shilman
Copy link
Member

shilman commented May 11, 2023

If you respond "n" it shouldn't ask you again until you clear your node_modules. Does it?

@nextlevelshit
Copy link

Where is the configuration to turn this off by default?

@dddcxy
Copy link

dddcxy commented Jul 20, 2023

I would also like to know where is the configuration to turn this off by default?

@dddcxy
Copy link

dddcxy commented Jul 20, 2023

我还想知道默认关闭此功能的配置在哪里?

i found it https://storybook.js.org/docs/react/configure/telemetry#crash-reports-disabled-by-default

@scmx
Copy link

scmx commented Sep 15, 2023

broken link above, try: https://storybook.js.org/docs/react/configure/telemetry#crash-reports-disabled-by-default

core: {
        enableCrashReports: false,
},

@httran13
Copy link

httran13 commented Oct 20, 2023

To disable this prompt entirely add this flag --disable-telemetry https://storybook.js.org/docs/react/configure/telemetry#how-to-opt-out

This will prevent the prompt Would you like to help improve Storybook by sending anonymous crash reports? that causes your ci server to hang

@maxpatiiuk
Copy link

We are using turbo build, so the CI doesn't print logs until command failed or succeeded.
Storybook's "Would you like to help improve Storybook by sending anonymous crash reports" hanged the CI machine, and we did not see anything in the logs since our turbo config doesn't print until process exits.

Took a while to debug that Storybook is the culprit

Doing interactive prompts in non-interactive environment (CI machine) is a bug - Storybook should not do that

@maxpatiiuk
Copy link

If you respond "n" it shouldn't ask you again until you clear your node_modules. Does it?

@shilman CI machines clear node_modules on each run

@shilman
Copy link
Member

shilman commented Jun 29, 2024

@tmeasday any recollection why we added this extra 'test' clause?

090fb35?diff=unified&w=0

@tmeasday
Copy link
Member

tmeasday commented Jul 1, 2024

I don't remember but I assume because we were trying to test the prompting. Perhaps we should use our own env var for this or something,.

@yannbf
Copy link
Member

yannbf commented Jul 3, 2024

This should be fixed in our upcoming Storybook 8.2 release!

@yannbf yannbf closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants