Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Theme of storybook #2423

Closed
Mujaddadi opened this issue Dec 4, 2017 · 27 comments
Closed

Change the Theme of storybook #2423

Mujaddadi opened this issue Dec 4, 2017 · 27 comments
Assignees
Milestone

Comments

@Mujaddadi
Copy link

Mujaddadi commented Dec 4, 2017

I am interested in customizing the UI of storybook. I am talking about the styles not just layout. At the moment the chances of changing it are zero to none. The UI even don't use classes so we can't overwrite it. Is there is anyway to do it without forking the repo? If it is, I will appreciate.

@majapw
Copy link

majapw commented Dec 6, 2017

We would also be interested in this feature. We use storybook to show off our internal design language, and it would be nice if we could leverage the features of the design language in the storybook as well.

A high-level styles object with a font stack, default spacing, colors, etc. would be a good start.

cc @noratarano

@stale
Copy link

stale bot commented Jan 24, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Jan 24, 2018
@Mujaddadi
Copy link
Author

I would like to work on it whenever I will get time, which I don't have at the moment.

@stale stale bot removed the inactive label Jan 26, 2018
@stale
Copy link

stale bot commented Mar 12, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Mar 12, 2018
@Mujaddadi
Copy link
Author

Not sure what's the point of the bot to close issues even if they are inactive. Doesn't solve the issue or fulfill feature request.

@danielduan
Copy link
Member

As an open source project, it's hard to accommodate every feature request ourselves. We use the bot to help close out any inactive issues so we spend more time coding and less time managing GitHub issues.

We do welcome any help we can get if anyone is interested in helping to implement support for theming. While there has been discussions about supporting theming, it isn't in our core roadmap in the near future.

@stale
Copy link

stale bot commented Apr 13, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 13, 2018
@uliana-sirotina
Copy link

Hi, we are also interested in adjusting the styles of storybook. If there could at least be a className for every part of the story. Like "story-header" etc.

@stale stale bot removed the inactive label Apr 23, 2018
@ckeeney
Copy link

ckeeney commented May 9, 2018

Is there a way to make stale bot ignore an issue? An issue has been created for this topic a number of times:

The stale bot repeatedly closing these issues just fragments the conversation.

@ndelangen
Copy link
Member

+1 on that @ckeeney. This is on the roadmap, I kinda like @uliana-sirotina idea as a intermediate solution.

I could do that, but it's also possibly easy enough for someone new to do it. Anyone here interested in taking it on?

@Mujaddadi
Copy link
Author

I would like to do it as my first open source project. Although I am quite busy but its time to give back to the community. I will check it on this Sunday hopefully.

@Keraito
Copy link
Contributor

Keraito commented May 10, 2018

If you need some help at some point, @Mujaddadi, I can gladly help, just @ me!

@Hypnosphi
Copy link
Member

Hypnosphi commented May 12, 2018

Does it mean that our layout will become a contract, and we won't be able to change it in non-major releases?

@igor-dv
Copy link
Member

igor-dv commented May 13, 2018

@Hypnosphi , probably you are right 🤔

@ndelangen
Copy link
Member

@Hypnosphi I would propose a few select global scope classes so there's some room for customisation there.

I'm already working on proper theming.

@Mujaddadi
Copy link
Author

@ckeeney and these issues are also been closed every time. I think this one is only the open issue.

@ndelangen So there is no need to work on the proper theming support since you are already working on it?

@ndelangen
Copy link
Member

ndelangen commented May 22, 2018

I am working on it, but would love to pair-program in it, if anyone is interested!

I can open a hangout and screen-share if anyone is interested. PM me https://twitter.com/norbertdelangen

@ndelangen ndelangen mentioned this issue Jun 4, 2018
5 tasks
@stale
Copy link

stale bot commented Jun 12, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added inactive and removed inactive labels Jun 12, 2018
@ndelangen ndelangen self-assigned this Jun 13, 2018
@thedaviddias
Copy link

Hey @everyone, I'm interested to work on that issue too... I'm currently working to build a new design system using storybook and I would like to easily add a different theme...

@ndelangen
Copy link
Member

@thedaviddias The theming PR has been merged ands the latest alpha release contains it!

So you can try this today!

I'd love to see what your custom theme will look like!!

@ndelangen ndelangen added this to the v4.0.0 milestone Jul 20, 2018
@Mujaddadi
Copy link
Author

Great! I will test it. Thanks!

@igor-dv
Copy link
Member

igor-dv commented Jul 20, 2018

Any reason to not closing this issue?

@ndelangen
Copy link
Member

no you're right we can close it

@issue-sh issue-sh bot removed the merged label Jul 20, 2018
@massivelines
Copy link

Love what has been setup on allowing customization on the UI, but it is still extremely limiting. I am building a living style guide for a web app, but I need to style the navigation and other things like the app.

One idea that I was thinking about that would allow tons of customization would be to use emotion-theming like its already setup in a few files, but instead of passing only a variables for a few changes, pass in an object and have the styling in a separate file or maybe multiple files.

Building on top of that idea, keep the current in file styling and use maybe like an if else, where as if styling has been set in a theme file use that instead of the in file styling.

@ndelangen
Copy link
Member

@massivelines I'm real happy with someone asking this.

I kept the theming PR limited on purpose so if this turned out too limited I would be able to hear from the requesters what their thoughts would be on what they want to change/theme in storybook.

I'd love to work with you and determine what sort of changes you'd want and how best to address them. Perhaps we could work together on a PR to hit a sweet spot of extensibility?

@massivelines
Copy link

@ndelangen I completely understand on keeping it limited and waiting on feedback.

I think working together on this is a great idea.

@ndelangen
Copy link
Member

Would you care to join our slack so we can discuss this a bit more direct?

https://now-examples-slackin-rrirkqohko.now.sh/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests