Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen reader announce irrelevant information as “[F]” for “Go full screen” and “Exit full screen” button. #27388

Open
msftedad opened this issue May 28, 2024 · 6 comments

Comments

@msftedad
Copy link

Describe the bug

Screen reader users will be affected if screen reader announce irrelevant information along with the controls.

Reproduction link

https://mgt.dev/?path=/docs/overview--docs

Reproduction steps

  1. Open the URL https://mgt.dev/?path=/docs/overview--docs

  2. Turn on Narrator using ‘Ctrl+win+enter’ keys.

  3. The ‘Microsoft Graph Toolkit Playground' Overview page will get displayed.

  4. Navigate to the ‘Go Full screen’ button.

  5. Observe the issue with the screen reader announcement.

Bug.3075.mp4

System

Test Environment: 
OS Build: Windows 11  
Version: 24H2 (OS Build 26058.1400)  
Browser: Edge dev  
Browser Version 123.0.2400.1 (Official build) dev (64-bit)

Additional context

Actual result:
Screen reader announce irrelevant information as “[F]” for “Go full screen” and “Exit full screen” button.

Expected Results:
Screen reader should not announce irrelevant information as “[F]” for “Go full screen” and “Exit full screen” button.

@Sranjan0208
Copy link

Sranjan0208 commented May 29, 2024

I inspected the page and from what I see the problem is within the button element.
image
As you can see the button element has an attribute title which says "Go Full Screen [F]", so the screen reader is reading that.
The fix is to provide an additional attribute called aria-label: "Go Full Screen" . This attribute will explicitly define what the screen reader should announce.

@msftedad
Copy link
Author

Hi @Sranjan0208, Any update on the fix?

@nick-fallon
Copy link

This has, apparently, been fixed.

Screen Shot 2024-06-09 at 1 31 46 AM

@msftedad
Copy link
Author

@nick-fallon, Thanks for the information.We have closed our issue.Thanks

@rishabhrthr001
Copy link

@msftedad if this issue is still open can i work on it

@msftedad
Copy link
Author

@rishabhrthr001, Thanks for following up, This issue is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants