Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom webpackDevMiddleware options? #32

Closed
awright415 opened this issue Apr 3, 2016 · 4 comments
Closed

Support for custom webpackDevMiddleware options? #32

awright415 opened this issue Apr 3, 2016 · 4 comments

Comments

@awright415
Copy link

I'd like to try out storybook in a Docker project that uses boot2docker (picking up the changes using webpack polling). Everything seems to work properly by providing a watchOptions.poll value in the webpackDevMiddleware options. Are you open to making those options configurable? If so, any preference on how it should be implemented?

(Edit: Included lazy: true as an option originally by mistake)

@arunoda
Copy link
Member

arunoda commented Apr 4, 2016

Yes. Sure. I'm open to that.

Let's do like this.

That's how I like to do it. But, I am open to suggestions.

@mking-clari
Copy link

mking-clari commented May 30, 2016

Here is another reason why this would be good. I would like to use React Storybook to test Redux containers which make API requests to my backend. I think there's room for a middle ground between developing the full-fledged app (which wouldn't use Storybook) and developing pure UI components (which wouldn't make API requests). For example, I have a search result container that I want to develop in isolation.

If we have webpack.devoptions.json, I can add a custom host and https to the middleware config.

@novascreen
Copy link

novascreen commented Feb 6, 2017

@awright415 what OS are you on?

I'm also trying to run Storybook inside of Docker (on Windows)

I tried adding

  watchOptions: {
    poll: 1000,
  },

to my webpack config and I see a bundle rebuilding, but after that nothing in Storybook actually updates.

ndelangen pushed a commit that referenced this issue Apr 5, 2017
Avoid adding custom query params to the state if its undefined
ndelangen pushed a commit that referenced this issue Apr 5, 2017
Now handles null default values for date knob
ndelangen pushed a commit that referenced this issue Apr 5, 2017
ndelangen pushed a commit that referenced this issue Apr 11, 2017
ndelangen added a commit that referenced this issue Apr 11, 2017
thani-sh pushed a commit that referenced this issue May 24, 2017
(self-merge) Update travis deployment to use GH_TOKEN variable encoded in secure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants