Make react an explicit dependency for Ember app

[gabrielcsapo]

Right now we make clients who are not using react bundle react, which seems a little confusing.

[gabrielcsapo]

@shilman @igor-dv continuing discussion here

[shilman]

For instance, see this PR: #4288

If we made react and react-dom a direct dep of all app/* packages, then this would be less confusing. @storybook/react and @storybook/react-native would still use peer deps to work with whatever version the user is already using.

@igor-dv @ndelangen @Hypnosphi @tmeasday Thoughts?

[tmeasday]

This seems like the right thing to do to me.

[igor-dv]

Yes. Agree.

[igor-dv]

With the same effort, let's maybe add babel-loader + @babel/core to the angular app since they don't really need babel themselves.

[gabrielcsapo]

@igor-dv you think we should do this in the same cleanup?

[igor-dv]

Yeah, why not?

[Hypnosphi]

@igor-dv I'm afraid we can't do that
#3335 (comment)

[Hypnosphi]

If we made react and react-dom a direct dep of all app/* packages

But we already have react and react-dom as a direct dep of all app/* packages except react. Both in 4.0 and 3.4

[Hypnosphi]

@gabrielcsapo which particular package doesn't have an explicit dependency on react at the moment?

[igor-dv]

I'm afraid we can't do that

@Hypnosphi, are you sure it's relevant to the Angular apps as well? Everything there is TS...

[igor-dv]

which particular package doesn't have an explicit dependency on react at the moment?

looks like ember app missed it

[Hypnosphi]

@igor-dv babel supports TS now, plus it can appear in node_modules because of being a dependency of some other third party package. What you suggest means relying on npm hoisting

[Hypnosphi]

ember app missed it

I see. @gabrielcsapo please add those dependencies to ember app

[gabrielcsapo]

Sorry for the delay just published a PR

[ndelangen]

Can we close this then? PR seems to be merged.