[ember] add dependencies to root application

[gabrielcsapo]

Issue: #4289

What I did

Add dependencies to the top level @storybook/ember application

[igor-dv]

Why is this moved?

[gabrielcsapo]

It is used in @storybook/ember and that's it.

[igor-dv]

Doesn't ember itself depend on this dep?

[gabrielcsapo]

no, it is used for outputting error information in the render function

[storybook-safe-bot]

	Fails
🚫	PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

[codecov]

Codecov Report

Merging #4309 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4309   +/-   ##
=======================================
  Coverage   40.23%   40.23%           
=======================================
  Files         510      510           
  Lines        5952     5952           
  Branches      795      795           
=======================================
  Hits         2395     2395           
  Misses       3172     3172           
  Partials      385      385

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a115420...abe6d8f. Read the comment docs.

[fran-worley]

@igor-dv since adding react and react-dom to my app dependencies it is now being recognised as a react app by storybook init.

Does the order of if statements in the app detection need reworking so ember is detected before react?

[igor-dv]

@Keraito is working on a CLI improvement where you will be able to pass a flag of the wanted framework. Probably react is one of the first apps to be checked...

[fran-worley]

@igor-dv I figured a simple solution would be to move the react clause to the end here

As I side note I see that ember isn't included here is that likely to cause issues for full ember support?

[igor-dv]

I figured a simple solution would be to move the react clause to the end here

yes, it will probably help, want to PR ?

As I side note I see that ember isn't included here is that likely to cause issues for full ember support?

I am less familiar with the CLI part. @Keraito @gabrielcsapo do you have something to say about this ?

[fran-worley]

@igor-dv compiling PR now.

As I side note I see that ember isn't included here is that likely to cause issues for full ember support?

Having now added 'ember' to that list, it is correctly detecting when storybook is already setup so I think it needs to be in there and I'll add to my PR in a separate commit.