-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When group specified for any knob, others without group are not displaying #4829
Comments
Having the same problem. |
We are experiencing the same issue. Having to add default groupId to all the knobs is a huge drag |
My project is suffering from this issue. Any chance for a fix? |
Any clue about the status of this issue? |
I think I more-or-less get what is happening: https://github.com/storybooks/storybook/blob/next/addons/knobs/src/components/Panel.js#L141-L163 The way the tabs work is, they're all rendered but only the selected one is not The problem is, there is no tab being created for the items that "don't have a group". That's what's supposed to be in place of the |
Fix #4829: render non-grouped knobs in the ALL tab
Yippee!! I just released https://github.com/storybooks/storybook/releases/tag/v4.2.0-alpha.10 containing PR #5106 that references this issue. Upgrade today to try it out! Because it's a pre-release you can find it on the |
Fix #4829: render non-grouped knobs in the ALL tab
Looks like this was released in https://github.com/storybooks/storybook/releases/tag/v4.1.7 already
(Incase anyone else was waiting for 4.2) |
When set group for knob in story other knobs, that dont have group, are not displaying in knobs panel
To Reproduce
Steps to reproduce the behavior:
text
for example)Expected behavior
Group 'All' should contain the knob without group
Screenshots
Code snippets
System:
The text was updated successfully, but these errors were encountered: