Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @storybook/polymer #6208

Closed
gugadev opened this issue Mar 20, 2019 · 20 comments
Closed

Deprecate @storybook/polymer #6208

gugadev opened this issue Mar 20, 2019 · 20 comments
Assignees
Milestone

Comments

@gugadev
Copy link

gugadev commented Mar 20, 2019

Looking at the present and future, I think holding the @storybook/polymer name is not very accurate anymore. In fact, that package is compatible with any native web components wrapper like lit-element, haunted, and so on (maybe stencil too).

For that reason I suggest change the name to @storybook/web-components or @storybook/custom-elements, it's more accurate than actual one. Same for @storybook/addon-web-components.

PD: I would help on those ackages 😃

@ndelangen
Copy link
Member

ndelangen commented Mar 22, 2019

I think that makes perfect sense TBH, We'd have to change some test names and maybe netlify sites names and such, but that's alls fairly straight forward.

Happy to accept your help offer @OWGUS!

Are you on our discord already?

@gugadev
Copy link
Author

gugadev commented Mar 22, 2019

I think that makes perfect sense TBH, We'd have to change some test names and maybe netlify sites names and such, but that's alls fairly straight forward.

@ndelangen That's great.

Are you on our discord already?

Yeah! I just joined (username: osgusdev)!

@daKmoR
Copy link
Contributor

daKmoR commented Apr 8, 2019

So what should be the name?

  • @storybook/web-components => probably used mostly by web component people
  • @storybook/lit-html => technically it just uses lit-html to render html with properties
    ?

@shilman
Copy link
Member

shilman commented Apr 8, 2019

I vote web-components

@gugadev
Copy link
Author

gugadev commented Apr 10, 2019

Yeah, is the most accurate name, IMO.

@stale stale bot added the inactive label May 1, 2019
@ndelangen
Copy link
Member

@gugadev would you open a PR?

@stale stale bot removed the inactive label May 6, 2019
@stale stale bot added the inactive label May 27, 2019
@emilio-martinez
Copy link
Contributor

I'd like to keep this open. 👋

@stale stale bot removed the inactive label May 28, 2019
@gugadev
Copy link
Author

gugadev commented Jun 1, 2019

Keep it open, currently I'm very busy but I'm working on the PR!

@shilman shilman added this to the 5.2.0 milestone Jun 1, 2019
@storybookjs storybookjs deleted a comment from stale bot Jun 3, 2019
@storybookjs storybookjs deleted a comment from stale bot Jun 3, 2019
@bashmish
Copy link
Contributor

So what should be the name?

  • @storybook/web-components => probably used mostly by web component people
  • @storybook/lit-html => technically it just uses lit-html to render html with properties
    ?

@storybook/lit-html is a more accurate name for what it does.

@shilman shilman modified the milestones: 5.2.0, 5.2.x Sep 23, 2019
@shilman shilman modified the milestones: 5.2.x, 5.3.x Jan 11, 2020
@shilman shilman added this to 6.0 breaking changes in Hotlist Jan 16, 2020
@shilman
Copy link
Member

shilman commented Jan 16, 2020

We have a @storybook/web-components now. Is anything further needed here? Should we deprecate this package somehow in 6.0? cc @ndelangen @daKmoR

@ndelangen
Copy link
Member

Yeah I think it's better to continue with web-components only in the long term.

Do you agree @daKmoR ?

@daKmoR
Copy link
Contributor

daKmoR commented Jan 21, 2020

jup, I agree - only polymer 2 (superseded by polymer 3 & lit-element) applications would still need it - HTML imports are not going to happen and that is the only reason you would stick with @storybook/polymer.

@ndelangen
Copy link
Member

Shall we just not update app/polymer anymore (and therefore remove it from the monorepo in 6.0.0) ?

@shilman
Copy link
Member

shilman commented Jan 21, 2020

YES PLEASE! 🙏

@ndelangen
Copy link
Member

consider it done, kinda sorry for @kroeder 's efforts to migrate it to TS

@shilman
Copy link
Member

shilman commented Jan 21, 2020

it'll go to storybook-eol repo?

@ndelangen
Copy link
Member

I'd have to extract it out, I don't know if I can do that preserving history, and all.

It will take more time. And for what gain exactly?

@shilman
Copy link
Member

shilman commented Jan 21, 2020

Probably into its own repo with a big fat deprecation warning at the top of the README. We can't just start deleting packages without warning. We need to deprecate the packages and give users time to migrate off. This means that for some amount of time, users need to be able to submit bugfixes or security fixes. I don't care if we have the git history preserved -- if people really want they can check the monorepo.

@ndelangen
Copy link
Member

https://github.com/storybookjs/polymer

@shilman shilman modified the milestones: 5.3.x, 6.0.0 Jan 22, 2020
@shilman
Copy link
Member

shilman commented Jan 23, 2020

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.1 containing PR #9596 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jan 23, 2020
@shilman shilman changed the title Change name of "Polymer" app/addon. Move @storybook/polymer to its own repo Jan 23, 2020
@shilman shilman changed the title Move @storybook/polymer to its own repo Deprecate @storybook/polymer Jan 23, 2020
@shilman shilman removed this from 6.0 breaking changes in Hotlist Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants