feat: adds new app "web-components" #8400

daKmoR · 2019-10-12T16:28:45Z

hey there 🤗

happy Hacktoberfest 💪

closes: #4958 #6208

What I did

Added a new app called web-components
Added a preset for addon-docs
Added a kitchen sink example
Transpiling code setup (e.g. most code is es7 even in node_modules so we need to mark that and compile it => also added info to the readme how you can add your own packages)
Added to generator
~~How to handle HMR? in the kitchen sync I currently force a hard refresh => I am using this since quite a while and it works fine even for bigger apps~~
=> documented howto add page refresh

It is sort of an alternative to #7731.

How to test

Open kitchen sink example

vercel · 2019-10-12T16:28:51Z

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/ixi568er6
🌍 Preview: https://monorepo-git-fork-dakmor-feat-web-components-app.storybook.now.sh

hsablonniere · 2019-10-14T11:32:21Z

I've been using hard refresh instead of HMR on our WC based storybook: works great.

https://www.clever-cloud.com/doc/clever-components/?path=/story/atoms--cc-button

daKmoR · 2019-10-14T12:22:47Z

@hsablonniere how did you implement the hard refresh?

shilman · 2019-10-14T13:08:54Z

Great work @daKmoR !!! Love that it includes the docs integration out of the box ❤️

daKmoR · 2019-10-15T20:47:54Z

anything else I can do to help?

I'm not really sure what that CI "Dangerfile" error is? It shows something about package-lock.json but we are only using yarn here right?

if there is no easy way of using full page reloads (instead of HMR) via the preset config then it would also be fine to "just" document it for now 🤗

ndelangen · 2019-10-15T21:01:32Z

Danger doesn't seem to work with forks:
https://help.github.com/en/articles/virtual-environments-for-github-actions
https://github.community/t5/GitHub-API-Development-and/Resource-not-accessible-by-integration-when-requesting-GitHub/m-p/14027#M182

daKmoR · 2019-10-18T16:54:13Z

So I updated and added all the needed documentation to get started. I also rebased to latest next branch.

@shilman @stijnkoopal may I request your review/approval 🤗

please let me know if there is anything else I should do 🤗

daKmoR · 2019-10-21T04:07:50Z

new week new energy 🤗 rebased for your convenience 🤗

shilman

So awesome. Let's merge this if it's ready!

hsablonniere · 2019-10-22T20:54:45Z

@daKmoR Not so sure but I use the @storybook/html and when I save, it does a hard refresh.

ndelangen · 2019-10-22T22:22:24Z

🎉

ericclemmons · 2019-10-23T00:03:31Z

Great work everyone! This will help converting my React components + stories to Stencil. 🤞

steel · 2019-10-23T04:03:44Z

I wrote this little diddy to get HMR working with our custom elements in storybook. https://github.com/polleverywhere/hmr-custom-element

If you are using Sass, also be sure to enable hmr in the MiniCssExtractPlugin if you are using that.

@todo

commit eee03b74ee8383d448908908ab77839ef5976207 Author: Leho Kraav <leho@kraav.com> Date: Mon Nov 11 15:31:39 2019 +0200 Help decorator support on Windows, fixup 7d294ae commit ba52bcd3e343034555dc4aa4da6b86988b5d2161 Author: Leho Kraav <leho@kraav.com> Date: Mon Nov 11 14:15:23 2019 +0200 Enable Pika build decorator support [1], fixup 7d294ae For some reason root `babel.config.js` is not recognized, or we don't know how to configure it. RESEARCH * FredKSchott/standard-pkg#9 * FredKSchott/standard-pkg@1a80ff5 * https://babeljs.io/docs/en/config-files#monorepos * https://github.com/web-padawan/aybolit/blob/v0.1.0/babel.config.js#L15 1: https://gitter.im/aybolitjs/community?at=5dc94b3d5eb2e813db04bdf4 commit 104c52aee026ab4f5d67ca0f9b5a18450fa4f46f Author: Leho Kraav <leho@kraav.com> Date: Mon Nov 11 12:12:18 2019 +0200 Upgrade Pika commit 55b9f6c858cbb2cb4214e68520fea4eec0ae5312 Author: Leho Kraav <leho@kraav.com> Date: Mon Nov 11 11:36:36 2019 +0200 Deploy Storybook to GH Pages commit bd2828a2574eb60baf77d4cccb3176929d3c24bb Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 22:34:43 2019 +0200 Improve context menu overlay position commit 9290851a43cefdc0126df1e1de09edc47b760fc2 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 21:40:31 2019 +0200 Add missing imports commit 4c9b3ae8bfdf474f91a70f69457da469aae471d8 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 20:37:48 2019 +0200 Refactor away from split button navigation [1] 1: https://www.nngroup.com/articles/split-buttons-navigation/ commit 37349e36d135b674bee1009e664f4c42710d802b Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 19:00:22 2019 +0200 More Global nav items, rename Shadow -> Global commit 7d294aec818fc3d7bebc2cf041ee98dd2a109b93 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 17:39:19 2019 +0200 Convert to TC39 decorators [1] 1: https://lit-element.polymer-project.org/guide/properties#declare-with-decorators commit 4a3eac799f2654d1749cdfd0d21c15500607a722 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 14:57:55 2019 +0200 CXL Live icon commit acbdbe38c05ecd912bfe4f2bcfb2b781e9fb06fd Author: Leho Kraav <leho@kraav.com> Date: Sat Nov 9 23:54:39 2019 +0200 Wip shadow menu commit 4f8623def1f3abe47333a413801fbd2b7e04ed85 Author: Leho Kraav <leho@kraav.com> Date: Sat Nov 9 15:50:17 2019 +0200 Storybook 5.3.0-alpha.42 [1] HMR full page reloads [2] 1: storybookjs/storybook#8400 2: https://github.com/storybookjs/storybook/tree/v5.3.0-alpha.42/app/web-components#user-content-setup-page-reload-via-hmr commit b71f42034d1496055a98d915e5425fc91c71c83d Author: Leho Kraav <leho@kraav.com> Date: Sat Nov 9 15:08:41 2019 +0200 Storybook 5.2.6 commit 58009c953cf3d32c938cf856204ac18c89c8f012 Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 19:22:06 2019 +0200 Search form label brand color commit ab9359d3af5682ebf4e617d64ee3e4897e64f093 Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 15:49:45 2019 +0200 Embedded search form can now receive all keyboard input commit 289535c2d591be2027c074e08710ac8f89ab04f4 Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 15:08:56 2019 +0200 Drop apparently unnecessary imports commit 7f61645f7e0809dd09f7af0411c49a2e0dad866e Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 14:24:31 2019 +0200 @todo refactor Resize event listener towards removable in `disconnectedCallback()` commit c58d6eea0ed4311fb72d79a77bf6321202d2354b Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 11:56:59 2019 +0200 Improve Search menu item form curiosities commit d40af0ecd12daa3d606b0289c748bcc3981738cc Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 10:02:14 2019 +0200 ESLint commit 519d17fc486072813a043e8ba8b96e4651b3bcc5 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 17:53:41 2019 +0200 Refactor fixed scroll listener, remove `that` pattern commit 5bfe7f52e04cea0914af74b46fbf5d2074730c30 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 17:01:01 2019 +0200 Integrate vaadin-tabs resize listener commit 0d368f2f356c554bed3fa2405210b8d8fd396348 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 16:34:20 2019 +0200 Refactor context menu dropdown icon vs menu item spacing commit 3590baf34cebc2f69b9b6291474381e66c52c1e3 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 16:44:41 2019 +0200 Align Search menu item template with general context menu items population strategy commit 409aed9bb159454b5f09702970cc635bda9a36c2 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 12:13:02 2019 +0200 Search menu item's full box should trigger context menu commit 16192b015834e3ead778279574571d95ed8597f5 Author: Leho Kraav <leho@kraav.com> Date: Tue Nov 5 14:59:11 2019 +0200 CSS class configuration for split nav menu item commit 4f099e1d313bb1cf62d8835c637a3dccf606d7eb Author: Leho Kraav <leho@kraav.com> Date: Tue Nov 5 14:39:55 2019 +0200 CXLMarketingNavElement.contextMenuItems property and configuration engine commit f30db212e2ac82c63459a136d4e7f08b9085281d Author: Leho Kraav <leho@kraav.com> Date: Tue Nov 5 13:00:20 2019 +0200 Move utility <nav> wrap to shadow DOM commit 6348064310227f1eca39b99ad08c783060e6260a Author: Leho Kraav <leho@kraav.com> Date: Tue Nov 5 11:14:31 2019 +0200 Refactor cxl-marketing-nav commit 9a5932738a636bd2bf4e091de4779dd3e7ac8ccd Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 3 17:33:50 2019 +0200 Integrated search box menu item @todo search input fails to take Space, Enter keydown [1] 1: vaadin/vaadin-context-menu#231 (comment) commit fa209831dade6884c0437d979dd104fa6542f6b3 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 3 17:43:40 2019 +0200 Match simple menu items HTML whitespace w/ complex commit 989ae01e19b2ff2a6d1f19fc767db6c938238e47 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 3 17:42:40 2019 +0200 Improve team invite menu item spacing commit fca1edebc911f7f1a3bf6eefe04ae0c251dd158e Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 3 17:44:32 2019 +0200 Add logo menu item dropdown commit cd9747da800bea2569ce31bec97a58ff57f9b4f2 Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 1 10:10:56 2019 +0200 Match `resizeVaadinTabs()` wide width w/ vaadin-context-menu [1] 1: https://github.com/vaadin/vaadin-context-menu/issues/253 commit f6584d21e00664683285975184fbea43653870bb Author: Leho Kraav <leho@kraav.com> Date: Thu Oct 31 19:25:22 2019 +0200 Upgrade to @vaadin/vaadin-context-menu-4.3.12 Ran into duplicate packages: "Custom element already defined" ``` $ yarn workspace @conversionxl/cxl-ui upgrade-interactive @vaadin/vaadin-context-menu $ yarn-deduplicate $ yarn ``` commit dbfbe243cd3e5369e61365f90f08abd1bed672fb Author: Leho Kraav <leho@kraav.com> Date: Thu Oct 31 19:22:17 2019 +0200 Make narrow viewport menu horizontal scroll icons visible commit 88f8572ced8f8c4cdfba20f3cc9ca9bddd93ac18 Author: Leho Kraav <leho@kraav.com> Date: Thu Oct 31 16:20:49 2019 +0200 Force vaadin-tab slotted links hover text-underline [1] `yarn workspace @conversionxl/cxl-ui upgrade-interactive @vaadin/vaadin-tabs` helped acquire @vaadin/vaadin-themable-mixin-1.5.0+ [2] 1: vaadin/vaadin-tabs#134 (comment) 2: https://github.com/vaadin/vaadin-themable-mixin/releases/tag/v1.5.0 commit cb678593820364c17f02323c8401488c3720d831 Author: Leho Kraav <leho@kraav.com> Date: Thu Oct 31 15:14:20 2019 +0200 Menu background color --lumo-black * Refactor cxl:logo SVG icon, 24px height * Add matching cxl:logo[theme=dark] icon * Avoid cxl-marketing-nav element margin collapse commit a3533b5174c29a1db8e6312735695e4547d9b99b Author: Leho Kraav <leho@kraav.com> Date: Wed Oct 30 21:28:39 2019 +0200 Partially revert 5cbc1b6, re-simplify story tree structure commit e7dbdb8411b8772a0fabb4d494911ac122121f01 Author: Leho Kraav <leho@kraav.com> Date: Wed Oct 30 21:15:56 2019 +0200 Increase dropdown icon hover visual prominence commit c2a5143f8e36c99b0e798055244f1398765f8c60 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 19:06:52 2019 +0200 Make vaadin-tabs orientation respond to window resize commit cf280c9537e49f8ccad2d1a38d8f78050d0f79e1 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 18:37:51 2019 +0200 Horizontal split navigation pattern commit d84596c07b3106951f368df5b03793774ae87f6a Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 18:37:21 2019 +0200 Add CXL logo menu item commit 4ada5e545a23cf1ec77ffc750433adf50ae70a62 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 17:20:26 2019 +0200 Context menu should open on "click" event commit 857c4bb33f31f09f726ca97912361b800c54b6e7 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 16:57:03 2019 +0200 Wrap vaadin-tabs in semantic nav element commit 141b3532468078dc9c8a611ce534d9dd427bad46 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 16:37:16 2019 +0200 Move context menu trigger outside menu item link commit 055d2e80c85ac82da2c185e3406b654107146061 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 16:27:59 2019 +0200 Prototype links inside vaadin-context-menu commit c8280c72f09ba4c2b98f6a5a2dbb2935b0b3ad49 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 15:46:35 2019 +0200 Many more contextMenuItems commit 9b57508ea38f60a478e22ed81abb2bf3142d34fa Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 08:57:00 2019 +0200 Nav container element (currently unknown) defaults to `display: inline`, we need `block` commit 4583f1729587ad14f340ea7f0cc3d2f52d334b9a Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 08:06:11 2019 +0200 Add links, drop unnecessary menu-item-depth classes commit eab7f786b851f2a7f7bdbe6623e60dc3a7761af7 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 08:04:27 2019 +0200 Eliminate viewport vertical scrollbar commit 5cbc1b6367cee0929756a33e6464f2ec630ac4b9 Author: Leho Kraav <leho@kraav.com> Date: Mon Oct 28 23:09:12 2019 +0200 Storybook CSF format commit 20dc156026eed03b9cb3df0b76bb663713cd9503 Author: Leho Kraav <leho@kraav.com> Date: Mon Oct 28 16:45:27 2019 +0200 Wip cxl-marketing-nav v2 prototype

@todo

commit eee03b74ee8383d448908908ab77839ef5976207 Author: Leho Kraav <leho@kraav.com> Date: Mon Nov 11 15:31:39 2019 +0200 Help decorator support on Windows, fixup 7d294ae commit ba52bcd3e343034555dc4aa4da6b86988b5d2161 Author: Leho Kraav <leho@kraav.com> Date: Mon Nov 11 14:15:23 2019 +0200 Enable Pika build decorator support [1], fixup 7d294ae For some reason root `babel.config.js` is not recognized, or we don't know how to configure it. RESEARCH * FredKSchott/standard-pkg#9 * FredKSchott/standard-pkg@1a80ff5 * https://babeljs.io/docs/en/config-files#monorepos * https://github.com/web-padawan/aybolit/blob/v0.1.0/babel.config.js#L15 1: https://gitter.im/aybolitjs/community?at=5dc94b3d5eb2e813db04bdf4 commit 104c52aee026ab4f5d67ca0f9b5a18450fa4f46f Author: Leho Kraav <leho@kraav.com> Date: Mon Nov 11 12:12:18 2019 +0200 Upgrade Pika commit 55b9f6c858cbb2cb4214e68520fea4eec0ae5312 Author: Leho Kraav <leho@kraav.com> Date: Mon Nov 11 11:36:36 2019 +0200 Deploy Storybook to GH Pages commit bd2828a2574eb60baf77d4cccb3176929d3c24bb Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 22:34:43 2019 +0200 Improve context menu overlay position commit 9290851a43cefdc0126df1e1de09edc47b760fc2 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 21:40:31 2019 +0200 Add missing imports commit 4c9b3ae8bfdf474f91a70f69457da469aae471d8 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 20:37:48 2019 +0200 Refactor away from split button navigation [1] 1: https://www.nngroup.com/articles/split-buttons-navigation/ commit 37349e36d135b674bee1009e664f4c42710d802b Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 19:00:22 2019 +0200 More Global nav items, rename Shadow -> Global commit 7d294aec818fc3d7bebc2cf041ee98dd2a109b93 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 17:39:19 2019 +0200 Convert to TC39 decorators [1] 1: https://lit-element.polymer-project.org/guide/properties#declare-with-decorators commit 4a3eac799f2654d1749cdfd0d21c15500607a722 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 10 14:57:55 2019 +0200 CXL Live icon commit acbdbe38c05ecd912bfe4f2bcfb2b781e9fb06fd Author: Leho Kraav <leho@kraav.com> Date: Sat Nov 9 23:54:39 2019 +0200 Wip shadow menu commit 4f8623def1f3abe47333a413801fbd2b7e04ed85 Author: Leho Kraav <leho@kraav.com> Date: Sat Nov 9 15:50:17 2019 +0200 Storybook 5.3.0-alpha.42 [1] HMR full page reloads [2] 1: storybookjs/storybook#8400 2: https://github.com/storybookjs/storybook/tree/v5.3.0-alpha.42/app/web-components#user-content-setup-page-reload-via-hmr commit b71f42034d1496055a98d915e5425fc91c71c83d Author: Leho Kraav <leho@kraav.com> Date: Sat Nov 9 15:08:41 2019 +0200 Storybook 5.2.6 commit 58009c953cf3d32c938cf856204ac18c89c8f012 Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 19:22:06 2019 +0200 Search form label brand color commit ab9359d3af5682ebf4e617d64ee3e4897e64f093 Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 15:49:45 2019 +0200 Embedded search form can now receive all keyboard input commit 289535c2d591be2027c074e08710ac8f89ab04f4 Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 15:08:56 2019 +0200 Drop apparently unnecessary imports commit 7f61645f7e0809dd09f7af0411c49a2e0dad866e Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 14:24:31 2019 +0200 @todo refactor Resize event listener towards removable in `disconnectedCallback()` commit c58d6eea0ed4311fb72d79a77bf6321202d2354b Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 11:56:59 2019 +0200 Improve Search menu item form curiosities commit d40af0ecd12daa3d606b0289c748bcc3981738cc Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 8 10:02:14 2019 +0200 ESLint commit 519d17fc486072813a043e8ba8b96e4651b3bcc5 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 17:53:41 2019 +0200 Refactor fixed scroll listener, remove `that` pattern commit 5bfe7f52e04cea0914af74b46fbf5d2074730c30 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 17:01:01 2019 +0200 Integrate vaadin-tabs resize listener commit 0d368f2f356c554bed3fa2405210b8d8fd396348 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 16:34:20 2019 +0200 Refactor context menu dropdown icon vs menu item spacing commit 3590baf34cebc2f69b9b6291474381e66c52c1e3 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 16:44:41 2019 +0200 Align Search menu item template with general context menu items population strategy commit 409aed9bb159454b5f09702970cc635bda9a36c2 Author: Leho Kraav <leho@kraav.com> Date: Thu Nov 7 12:13:02 2019 +0200 Search menu item's full box should trigger context menu commit 16192b015834e3ead778279574571d95ed8597f5 Author: Leho Kraav <leho@kraav.com> Date: Tue Nov 5 14:59:11 2019 +0200 CSS class configuration for split nav menu item commit 4f099e1d313bb1cf62d8835c637a3dccf606d7eb Author: Leho Kraav <leho@kraav.com> Date: Tue Nov 5 14:39:55 2019 +0200 CXLMarketingNavElement.contextMenuItems property and configuration engine commit f30db212e2ac82c63459a136d4e7f08b9085281d Author: Leho Kraav <leho@kraav.com> Date: Tue Nov 5 13:00:20 2019 +0200 Move utility <nav> wrap to shadow DOM commit 6348064310227f1eca39b99ad08c783060e6260a Author: Leho Kraav <leho@kraav.com> Date: Tue Nov 5 11:14:31 2019 +0200 Refactor cxl-marketing-nav commit 9a5932738a636bd2bf4e091de4779dd3e7ac8ccd Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 3 17:33:50 2019 +0200 Integrated search box menu item @todo search input fails to take Space, Enter keydown [1] 1: vaadin/vaadin-context-menu#231 (comment) commit fa209831dade6884c0437d979dd104fa6542f6b3 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 3 17:43:40 2019 +0200 Match simple menu items HTML whitespace w/ complex commit 989ae01e19b2ff2a6d1f19fc767db6c938238e47 Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 3 17:42:40 2019 +0200 Improve team invite menu item spacing commit fca1edebc911f7f1a3bf6eefe04ae0c251dd158e Author: Leho Kraav <leho@kraav.com> Date: Sun Nov 3 17:44:32 2019 +0200 Add logo menu item dropdown commit cd9747da800bea2569ce31bec97a58ff57f9b4f2 Author: Leho Kraav <leho@kraav.com> Date: Fri Nov 1 10:10:56 2019 +0200 Match `resizeVaadinTabs()` wide width w/ vaadin-context-menu [1] 1: https://github.com/vaadin/vaadin-context-menu/issues/253 commit f6584d21e00664683285975184fbea43653870bb Author: Leho Kraav <leho@kraav.com> Date: Thu Oct 31 19:25:22 2019 +0200 Upgrade to @vaadin/vaadin-context-menu-4.3.12 Ran into duplicate packages: "Custom element already defined" ``` $ yarn workspace @conversionxl/cxl-ui upgrade-interactive @vaadin/vaadin-context-menu $ yarn-deduplicate $ yarn ``` commit dbfbe243cd3e5369e61365f90f08abd1bed672fb Author: Leho Kraav <leho@kraav.com> Date: Thu Oct 31 19:22:17 2019 +0200 Make narrow viewport menu horizontal scroll icons visible commit 88f8572ced8f8c4cdfba20f3cc9ca9bddd93ac18 Author: Leho Kraav <leho@kraav.com> Date: Thu Oct 31 16:20:49 2019 +0200 Force vaadin-tab slotted links hover text-underline [1] `yarn workspace @conversionxl/cxl-ui upgrade-interactive @vaadin/vaadin-tabs` helped acquire @vaadin/vaadin-themable-mixin-1.5.0+ [2] 1: vaadin/vaadin-tabs#134 (comment) 2: https://github.com/vaadin/vaadin-themable-mixin/releases/tag/v1.5.0 commit cb678593820364c17f02323c8401488c3720d831 Author: Leho Kraav <leho@kraav.com> Date: Thu Oct 31 15:14:20 2019 +0200 Menu background color --lumo-black * Refactor cxl:logo SVG icon, 24px height * Add matching cxl:logo[theme=dark] icon * Avoid cxl-marketing-nav element margin collapse commit a3533b5174c29a1db8e6312735695e4547d9b99b Author: Leho Kraav <leho@kraav.com> Date: Wed Oct 30 21:28:39 2019 +0200 Partially revert 5cbc1b6, re-simplify story tree structure commit e7dbdb8411b8772a0fabb4d494911ac122121f01 Author: Leho Kraav <leho@kraav.com> Date: Wed Oct 30 21:15:56 2019 +0200 Increase dropdown icon hover visual prominence commit c2a5143f8e36c99b0e798055244f1398765f8c60 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 19:06:52 2019 +0200 Make vaadin-tabs orientation respond to window resize commit cf280c9537e49f8ccad2d1a38d8f78050d0f79e1 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 18:37:51 2019 +0200 Horizontal split navigation pattern commit d84596c07b3106951f368df5b03793774ae87f6a Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 18:37:21 2019 +0200 Add CXL logo menu item commit 4ada5e545a23cf1ec77ffc750433adf50ae70a62 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 17:20:26 2019 +0200 Context menu should open on "click" event commit 857c4bb33f31f09f726ca97912361b800c54b6e7 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 16:57:03 2019 +0200 Wrap vaadin-tabs in semantic nav element commit 141b3532468078dc9c8a611ce534d9dd427bad46 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 16:37:16 2019 +0200 Move context menu trigger outside menu item link commit 055d2e80c85ac82da2c185e3406b654107146061 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 16:27:59 2019 +0200 Prototype links inside vaadin-context-menu commit c8280c72f09ba4c2b98f6a5a2dbb2935b0b3ad49 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 15:46:35 2019 +0200 Many more contextMenuItems commit 9b57508ea38f60a478e22ed81abb2bf3142d34fa Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 08:57:00 2019 +0200 Nav container element (currently unknown) defaults to `display: inline`, we need `block` commit 4583f1729587ad14f340ea7f0cc3d2f52d334b9a Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 08:06:11 2019 +0200 Add links, drop unnecessary menu-item-depth classes commit eab7f786b851f2a7f7bdbe6623e60dc3a7761af7 Author: Leho Kraav <leho@kraav.com> Date: Tue Oct 29 08:04:27 2019 +0200 Eliminate viewport vertical scrollbar commit 5cbc1b6367cee0929756a33e6464f2ec630ac4b9 Author: Leho Kraav <leho@kraav.com> Date: Mon Oct 28 23:09:12 2019 +0200 Storybook CSF format commit 20dc156026eed03b9cb3df0b76bb663713cd9503 Author: Leho Kraav <leho@kraav.com> Date: Mon Oct 28 16:45:27 2019 +0200 Wip cxl-marketing-nav v2 prototype

daKmoR requested review from ndelangen, shilman and stijnkoopal as code owners October 12, 2019 16:28

vercel bot deployed to staging October 12, 2019 16:28 View deployment

shilman added feature request html labels Oct 14, 2019

ndelangen approved these changes Oct 15, 2019

View reviewed changes

daKmoR force-pushed the feat/web-components-app branch from 295d716 to 55f3b6d Compare October 18, 2019 16:43

vercel bot temporarily deployed to staging October 18, 2019 16:43 Inactive

daKmoR force-pushed the feat/web-components-app branch from 55f3b6d to 4dc15ec Compare October 18, 2019 16:51

vercel bot deployed to staging October 18, 2019 16:51 View deployment

ndelangen self-assigned this Oct 18, 2019

daKmoR force-pushed the feat/web-components-app branch from 4dc15ec to d5c0b4e Compare October 18, 2019 18:07

vercel bot deployed to staging October 18, 2019 18:07 View deployment

feat: adds new app "web-components"

ea1e2e4

daKmoR force-pushed the feat/web-components-app branch from d5c0b4e to ea1e2e4 Compare October 21, 2019 03:50

vercel bot deployed to staging October 21, 2019 03:50 View deployment

shilman approved these changes Oct 22, 2019

View reviewed changes

shilman mentioned this pull request Oct 22, 2019

Framework support - Stencil.js #4600

Closed

ndelangen merged commit 1989796 into storybookjs:next Oct 22, 2019

ndelangen added this to the 5.3.0 milestone Oct 23, 2019

lonyele mentioned this pull request Oct 25, 2019

[Try] Add support for LitElement #7731

Closed

shilman added the web-components label Nov 18, 2019

dependencies bot mentioned this pull request Jan 15, 2021

Update eslint from 4.8.0 to 4.9.0 in / #2054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adds new app "web-components" #8400

feat: adds new app "web-components" #8400

daKmoR commented Oct 12, 2019 •

edited

vercel bot commented Oct 12, 2019 •

edited

hsablonniere commented Oct 14, 2019

daKmoR commented Oct 14, 2019

shilman commented Oct 14, 2019

daKmoR commented Oct 15, 2019

ndelangen commented Oct 15, 2019

daKmoR commented Oct 18, 2019

daKmoR commented Oct 21, 2019

shilman left a comment

hsablonniere commented Oct 22, 2019

ndelangen commented Oct 22, 2019

ericclemmons commented Oct 23, 2019

steel commented Oct 23, 2019

feat: adds new app "web-components" #8400

feat: adds new app "web-components" #8400

Conversation

daKmoR commented Oct 12, 2019 • edited

What I did

How to test

vercel bot commented Oct 12, 2019 • edited

hsablonniere commented Oct 14, 2019

daKmoR commented Oct 14, 2019

shilman commented Oct 14, 2019

daKmoR commented Oct 15, 2019

ndelangen commented Oct 15, 2019

daKmoR commented Oct 18, 2019

daKmoR commented Oct 21, 2019

shilman left a comment

Choose a reason for hiding this comment

hsablonniere commented Oct 22, 2019

ndelangen commented Oct 22, 2019

ericclemmons commented Oct 23, 2019

steel commented Oct 23, 2019

daKmoR commented Oct 12, 2019 •

edited

vercel bot commented Oct 12, 2019 •

edited