-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escaped Pipe creates new table cell #6869
Comments
Same issue here, unfortunately. I wanted to try and find the root cause, and checked the markdown-to-jsx library for clues, but no similar issue reported there. Anyone have any insights into what part of the code or library is parsing this wrong? |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
I could investigate this further, and maybe attempt a fix, but would be helpful with some pointers on where in the code to look - or if it's entirely a markdown-to-jsx issue. Pinging some recently active contributors @Gongreg @tmeasday @ndelangen @danielduan. |
Hey,
this is all ondevice-notes addon is doing. |
@Gongreg Thanks! I will try to reproduce with plain markdown-to-jsx, and report any findings to their project. Propose to keep this open for now, for visibility. |
This has now been fixed in latest markdown-to-jsx release, Submitted a PR to upgrade the |
Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.24 containing PR #7694 that references this issue. Upgrade today to try it out! You can find this prerelease on the |
Describe the bug
In Storybook-Addon-Notes: I'm using markdown-files with tables. Inside a table-cell I use escaped pipes. These pipes are creating new cells
To Reproduce
Steps to reproduce the behavior:
Which should render this:
position
"left" | "right"
But it actually renders like this:
position
"left"
"right"
Expected behavior
Do not ignore escaped pipes. Do not create new table cells.
Screenshots
![table](https://user-images.githubusercontent.com/13744542/58240736-e20c8000-7d4b-11e9-9873-2b86fb97ba24.png)
System:
The text was updated successfully, but these errors were encountered: