-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storybook RN server not refreshing stories #7017
Comments
I did a small investigation and found that if I upgraded all to then manually restore back both |
I have a same problem in @storybook/react-native-server": "5.1.3" 5.1.8 is also. |
Have the same issue in @storybook/react-native-server": "5.1.7" |
We are exactly suffering the same issue, and for us is even worse, because we are using WebSockets to select the story in our Automation test to check the content is the proper one. Thanks |
@edward-s Does this screencast reflect the issue you're describing? https://drive.google.com/open?id=1KrkFttWi__MM8C2ms3hXIr1C3YYR1VdJ |
Exactly same. |
Also reflects what I am experiencing at edit: Refreshing in the browser after selecting a story functions successfully as a workaround here too. |
@shilman I put together a fresh expo/storybook repo to illustrate.
|
Hey, I think this issue is related to #4716. It already has a fix and should be released soon. |
Hey, |
Confirmed it's working. For anyone wanting to save a few minutes on upgrading before testing, here's a sample repo upgraded to 35a: |
It works well with
|
I have updated to this version and now the stories are not loading. |
Did you try to start storybook with
|
Changes: - Update storybook version to fix refresh issue, see storybookjs/storybook#7017 - Update storybook script to include react-native start - Mock out STORYBOOK_HOOKS_CONTEXT - Update storybook section in README
Changes: - Update storybook version to fix refresh issue, see storybookjs/storybook#7017 - Update storybook script to include react-native start - Mock out STORYBOOK_HOOKS_CONTEXT - Update storybook section in README
Between 5.1.0-rc.4 and 5.1.3, Storybook RN server is no longer refreshing stories displayed on iOS simulator.
Steps to reproduce:
@storybook/react-native-server": "5.1.3"
localhost:7007
and click on any storyselected story loads correctly without the above error in
@storybook/react-native-server": "5.1.0-rc.4"
, but fails with error in5.1.0-rc.5
or5.1.3
The text was updated successfully, but these errors were encountered: