Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook with Polymer does not work in Internet Explorer 11 #7995

Closed
michael-breazeale opened this issue Sep 4, 2019 · 6 comments
Closed

Comments

@michael-breazeale
Copy link

michael-breazeale commented Sep 4, 2019

Describe the bug 🔍

Unable to view storybook polymer example on Internet Explorer 11. This also occurs on local, but since it's presenting on the example that seems to be the best place to focus.

To Reproduce 💥

Steps to reproduce the behavior:

  1. Open IE 11 (My version is 11.950.17134.0)
  2. Open Developer console if you want to see the errors in the log.
  3. Go to 'https://storybooks-polymer.netlify.com/'
  4. See error

Expected behavior ✨

The working story book that shows in Chrome.

Screenshots 📸

image

image

With chrome we see:
image

Context👨‍💻

  • Device: Computer/PC
  • OS: Windows 10 Enterprise (Version 1803 Build 17134.95)
  • Browser: Internet Explorer 11
  • Browser version: 11.950.17134.0
  • Storybook Version: 5.1.11
@michael-breazeale
Copy link
Author

michael-breazeale commented Sep 4, 2019

#7093 #7263 And other IE 11 issues might help. I think there must be some missing polyfills. I've tried the workaround in #4099 with no success (but I didn't expect that since it's from v4).

@shilman
Copy link
Member

shilman commented Sep 4, 2019

Which version of storybook are you running? I think the netlify deploys are outdated (cc @ndelangen)

@michael-breazeale
Copy link
Author

@shilman Storybook 5.1.11

@michael-breazeale
Copy link
Author

In testing, I created an empty storybook project.

npx -p @storybook/cli sb init

Selected Polymer manually.

Manually added lit-element because it's not added via the init, resulting in the following package.json:

{
  "dependencies": {
    "lit-element": "^2.2.1"
  },
  "devDependencies": {
    "@babel/core": "^7.5.5",
    "@storybook/polymer": "^5.1.11",
    "babel-loader": "^8.0.6",
    "polymer-webpack-loader": "^2.0.3"
  },
  "scripts": {
    "storybook": "start-storybook -p 6006",
    "build-storybook": "build-storybook"
  }
}

Even with an empty index.stories.js

I see this in Internet Explorer:
image

image

And this in Chrome:

image

image

@michael-breazeale
Copy link
Author

It may be related to this lit-html issue: lit/lit#873

@michael-breazeale
Copy link
Author

I was able to get the error to go away in IE 11 with the webpack config in this issue:

#7084 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants