Add pop-out button to open preview in a new window #862
Labels
Comments
|
I think this should be a keyboard shortcut. Button would work too, if we can find a good place to put it. |
|
I suppose we could put it into this menu #867 |
JGAntunes
added a commit
to newsuk/times-components
that referenced
this issue
Jun 23, 2017
Storybook relies on iframes to render stories, gpt map sizes, used to build responsive ads don't seem to work with it. This hack solves it for now until further developments on storybookjs/storybook#862
JGAntunes
added a commit
to newsuk/times-components
that referenced
this issue
Jun 23, 2017
Storybook relies on iframes to render stories, gpt map sizes, used to build responsive ads don't seem to work with it. This hack solves it for now until further developments on storybookjs/storybook#862
JGAntunes
added a commit
to newsuk/times-components
that referenced
this issue
Jul 4, 2017
Storybook relies on iframes to render stories, gpt map sizes, used to build responsive ads don't seem to work with it. This hack solves it for now until further developments on storybookjs/storybook#862
JGAntunes
added a commit
to newsuk/times-components
that referenced
this issue
Jul 5, 2017
Storybook relies on iframes to render stories, gpt map sizes, used to build responsive ads don't seem to work with it. This hack solves it for now until further developments on storybookjs/storybook#862
sericaia
pushed a commit
to newsuk/times-components
that referenced
this issue
Jul 7, 2017
Storybook relies on iframes to render stories, gpt map sizes, used to build responsive ads don't seem to work with it. This hack solves it for now until further developments on storybookjs/storybook#862
|
There's full-screen mode. So this would add a button to switch to full-screen mode.. because actually popping the preview out seems odd, what will take it's place? I would like a button that will open an additional preview. But that's an other issue #1335 Given @usulpro's PR is already open, and is larger in scope then this issue, I'm going to go ahead an close this. |
craigbilner
pushed a commit
to newsuk/times-components
that referenced
this issue
Jul 10, 2017
* feature: add gpt component with support for header biding * fix: deal with some issues in the gpt story * fix: render ad inside storybook Storybook relies on iframes to render stories, gpt map sizes, used to build responsive ads don't seem to work with it. This hack solves it for now until further developments on storybookjs/storybook#862 * chore: document gpt story hack * chore: add tests for gpt, pbjs and ad managers * chore: add more tests for ad manager * add more tests to ad-manager * fixes here and there (console.log, typos, etc) * classes instead of functions * corrected most comments [WIP] * snapshot test * change story to render two ads in article page * quick refactor on ad manager test * alternative using react broadcast * fix tests [WIP] * snapshot tests; pbjs config; tests adapted * fix: add missing react-broadcast dep * chore: redo initialisation checks on ad, gpt and pbjs managers * remove old test * fix: jest config on gpt component * chore: remove unneeded JSDOM dev dep * fix: add section as a prop of ad composer * fix: return on all callbacks * chore: lint gpt component * fix: network id should be a prop of AdManager * chore: add comments on gpt config * chore: use promises on the gpt, pbjs and ad managers * chore: remove errors on improper class usage * CC linting err fixed; adUnit as prop * remove new.target as class constructors need to be called with new anyway * chore: increase coverage * one more test * chore: update jest configuration * prebid settings unit tests * fix: change test assumption titles * fix: test message to remember to turn ad blocker off * fix: throw error if slot does not exist * fix: use storybook url and remove transform
rjanjua
pushed a commit
to newsuk/times-components
that referenced
this issue
Jul 10, 2017
* feature: add gpt component with support for header biding * fix: deal with some issues in the gpt story * fix: render ad inside storybook Storybook relies on iframes to render stories, gpt map sizes, used to build responsive ads don't seem to work with it. This hack solves it for now until further developments on storybookjs/storybook#862 * chore: document gpt story hack * chore: add tests for gpt, pbjs and ad managers * chore: add more tests for ad manager * add more tests to ad-manager * fixes here and there (console.log, typos, etc) * classes instead of functions * corrected most comments [WIP] * snapshot test * change story to render two ads in article page * quick refactor on ad manager test * alternative using react broadcast * fix tests [WIP] * snapshot tests; pbjs config; tests adapted * fix: add missing react-broadcast dep * chore: redo initialisation checks on ad, gpt and pbjs managers * remove old test * fix: jest config on gpt component * chore: remove unneeded JSDOM dev dep * fix: add section as a prop of ad composer * fix: return on all callbacks * chore: lint gpt component * fix: network id should be a prop of AdManager * chore: add comments on gpt config * chore: use promises on the gpt, pbjs and ad managers * chore: remove errors on improper class usage * CC linting err fixed; adUnit as prop * remove new.target as class constructors need to be called with new anyway * chore: increase coverage * one more test * chore: update jest configuration * prebid settings unit tests * fix: change test assumption titles * fix: test message to remember to turn ad blocker off * fix: throw error if slot does not exist * fix: use storybook url and remove transform
fampinheiro
pushed a commit
to newsuk/times-components
that referenced
this issue
Jul 14, 2017
* feature: add gpt component with support for header biding * fix: deal with some issues in the gpt story * fix: render ad inside storybook Storybook relies on iframes to render stories, gpt map sizes, used to build responsive ads don't seem to work with it. This hack solves it for now until further developments on storybookjs/storybook#862 * chore: document gpt story hack * chore: add tests for gpt, pbjs and ad managers * chore: add more tests for ad manager * add more tests to ad-manager * fixes here and there (console.log, typos, etc) * classes instead of functions * corrected most comments [WIP] * snapshot test * change story to render two ads in article page * quick refactor on ad manager test * alternative using react broadcast * fix tests [WIP] * snapshot tests; pbjs config; tests adapted * fix: add missing react-broadcast dep * chore: redo initialisation checks on ad, gpt and pbjs managers * remove old test * fix: jest config on gpt component * chore: remove unneeded JSDOM dev dep * fix: add section as a prop of ad composer * fix: return on all callbacks * chore: lint gpt component * fix: network id should be a prop of AdManager * chore: add comments on gpt config * chore: use promises on the gpt, pbjs and ad managers * chore: remove errors on improper class usage * CC linting err fixed; adUnit as prop * remove new.target as class constructors need to be called with new anyway * chore: increase coverage * one more test * chore: update jest configuration * prebid settings unit tests * fix: change test assumption titles * fix: test message to remember to turn ad blocker off * fix: throw error if slot does not exist * fix: use storybook url and remove transform
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Saturday Jul 02, 2016 at 02:24 GMT
Originally opened as storybook-eol/storybook-ui#10
It seems it can be useful in some use-cases if we can use a new window for the preview instead of an iframe:
CC: @ritz078
The text was updated successfully, but these errors were encountered: