Since ReactDOM 15.4 is out, the require hijack should be removed from version 2

[shilman]

Issue by imontiel
Monday Mar 20, 2017 at 21:00 GMT
Originally opened as storybook-eol/storyshots#90

---

Since ReactDOM 15.4.* is out, the require hijack should be removed so that stories that use overlays (such as react-bootstrap's OverlayTrigger) can be tested.

Currently, in run_storyshots.js, the ReactDOM dependency is hijacked. This means any story that uses unstable_renderSubtreeIntoContainer or any other function provided by ReactDOM (such as any of the functionality provided here) cannot be tested.

I have a current work around where I invoke the cli directly:

NODE_ENV=test node ./node_modules/storyshots/dist/cli.js

I guess the easiest solution is to remove the hijack, change the ReactDOM dependency to ^15.4.0 and upversion to 3.3.0?

[ndelangen]

Is this issue still current?

Please re-open if it's still something we need to do / fix 👍