Set ESlint rules more strict 🚑 #1000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/addon-graphql/package.json # packages/addon-info/package.json # packages/addon-info/src/components/Node.js # packages/addon-knobs/package.json # packages/addon-notes/package.json # packages/channel-postmessage/package.json # packages/channel-websocket/package.json # packages/decorator-centered/package.json # packages/react-native-storybook/package.json # packages/react-storybook/src/server/config.js # packages/storybook-ui/package.json # packages/storybook-ui/src/modules/ui/components/layout/index.js
notes: 1. did not resolve `jsx-a11y` errors as that would require closer attention to the browser 2. did not resolve any `'enzyme' should be listed in the project's dependencies. Run 'npm i -S enzyme' to add it import/no-extraneous-dependencies` see note: #911 (comment)
adds `global` as the dep was missing in add-on-knobs
didn’t resolve jsx-a11y linting in this pass
uses `toMatchObject` rather than `toEqual` to be more lenient about what props are present
… the eslint config for globals
…`import/no-extraneous-dependencies` linter warning
…t` to resolve `import/no-extraneous-dependencies` lint issue
note: didn’t tackle jsx-a11y on this pass.
14 tasks
ndelangen
referenced
this pull request
in airbnb/javascript
May 9, 2017
of airbnb/javascript@121a95d UPDATED dependencies CHANGED devDependencies linting ADD enzyme and storybook-addon to devDependencies in a few packages
|
✖ 67 problems (57 errors, 10 warnings) |
# Conflicts: # addons/centered/package.json # addons/graphql/package.json # addons/info/package.json # addons/knobs/package.json # addons/links/.storybook/config.js # addons/notes/package.json # addons/notes/src/index.js # addons/notes/src/register.js # addons/options/src/manager/index.js # addons/storyshots/src/index.js # addons/storyshots/stories/required_with_context/Button.stories.js # addons/storyshots/stories/required_with_context/Welcome.js # app/react-native/package.json # app/react-native/src/manager/index.js # lib/channel-postmessage/package.json # lib/channel-postmessage/src/index.js # lib/channel-websocket/package.json # lib/channel-websocket/src/index.js # lib/cli/generators/METEOR/index.js # lib/cli/generators/REACT/template/stories/Welcome.js # lib/cli/generators/REACT_SCRIPTS/index.js # lib/cli/generators/WEBPACK_REACT/template/stories/Welcome.js # packages/react-storybook/src/server/track_usage.js # packages/storybook-ui/src/modules/ui/components/layout/usplit.js # scripts/prepublish.js
ndelangen
approved these changes
May 19, 2017
Closed
|
@theinterned @ndelangen sorry I missed that this was waiting for my review. We need to get this merged, see e.g. #1163 @theinterned do you mind resolving the merge conflicts and we can get this merged to do a follow-on release? Who knows what other bugs are lurking behind this PR! 😱 |
|
closed in favour of #911 |
|
Hi sorry I didn't reply! I was on vacation. Looks like you've got things sorted here though! I'll see if I can help out on the #911 branch |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 08a49db. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: -should create one-
What I did
As described in review comments #904 linting is rather non-strict right now.
Though I'm personally of the opinion too strict linting can be harmful, I agree, we could make it a bit more strict to weed out some bad code we have and prevent bad come from getting pushed to master.
How to test
run
npm run lint