Addon-Toolbars: Global args support in the toolbar #10028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
|
Thanks for creating this! The first look really promising to me. It did solve the pain point I was facing on porting the addon with other frameworks. Really well done guys! I will dive in deeper to see if anything I can suggest to make it even better. |
shilman
requested review from
aaronmcadam,
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
danielduan,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh and
renaudtertrais
as code owners
shilman
requested review from
saponifi3d,
stijnkoopal,
theinterned,
thomasbertet and
z4o4z
as code owners
|
@shilman where do the icons come from? e.g. where can I know which icons I can use? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Created
addon-toolbars, an evolution ofaddon-contexts, based on Storybook's new Global Args feature and decorators.This addon allows people to easily create custom toolbars that set global variables which are accessible from within decorators and stories. See included README for details.
How to test
See included toolbar stories in
official-storybook