Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Show Code Open by default #10431

Closed
wants to merge 3 commits into from
Closed

docs: Show Code Open by default #10431

wants to merge 3 commits into from

Conversation

kschoi
Copy link

@kschoi kschoi commented Apr 15, 2020

Issue: #10430

What I did

I added 'previewSource' parameter.

How to test

API is following

addParameters({ docs: { previewSource: 'open' } })

@ndelangen
Copy link
Member

@shilman what do you think? Do we want to add this?

@shilman
Copy link
Member

shilman commented Jun 5, 2020

@ndelangen I think it's a good feature but I want to think a little about how to make the story parameters and doc blocks props line up and I haven't had a chance to work it out.

@kschoi sorry for the slow response on this... really appreciate your contribution & patience!

@shilman shilman added the tracked label Aug 3, 2020
@shilman shilman self-assigned this Aug 3, 2020
@shilman shilman removed the tracked label Mar 30, 2021
@shilman
Copy link
Member

shilman commented Apr 29, 2021

Hi @kschoi! Thanks so much for making this PR. I merged #14729 which implements the same feature, so I'm going to close this.

@shilman shilman closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants