Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX auto refs when there are no specified refs #11057

Merged
merged 4 commits into from
Jun 11, 2020
Merged

FIX auto refs when there are no specified refs #11057

merged 4 commits into from
Jun 11, 2020

Conversation

ndelangen
Copy link
Member

Issue: -autorefs aren't loaded if there are no manual refs specified-

What I did

  • FIX it so autoRefs do get loaded

@ndelangen ndelangen added the bug label Jun 5, 2020
@ndelangen ndelangen added this to the 6.0 milestone Jun 5, 2020
@ndelangen ndelangen self-assigned this Jun 5, 2020
@ndelangen ndelangen requested a review from shilman June 5, 2020 18:02
shilman
shilman requested changes Jun 6, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change

lib/core/src/server/manager/manager-config.js Outdated Show resolved Hide resolved
@ndelangen
Copy link
Member Author

@shilman happy with the changes?

@ndelangen ndelangen requested a review from shilman June 10, 2020 14:07
shilman
shilman approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@ndelangen ndelangen merged commit eebad1a into next Jun 11, 2020
@ndelangen ndelangen deleted the fix/autorefs branch June 11, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
bug
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndelangen @shilman