New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Pass --quiet to disable HMR logging in browser console #11087
Conversation
Pass the CLI `--quiet` option to the hot module replacement client instead of hardcoding it in development builds. A minor improvement to 60961d3 (#9535). #8461 (comment)
I believe this is a false positive:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me. I'm assuming errors still show up?
@shilman, I should have done more research. Sorry about that. What I'm seeing is that this will suppress all warnings too. I believe errors are always logged but there's some inconsistencies in the logging (e.g., see the warning checking in process-update). There's a |
Try it? As long as it’s opt in, we can do whatever you think is most useful |
Revise --quiet to allow hot module replacement warnings to be logged. webpack-hot-middleware's `quiet` parameter suppress warnings so `noInfo` is used instead.
Thanks, @shilman! I've passed the quiet option to |
Looks good @niedzielski! I'll let @ndelangen take a look before merging |
Yay! Thank you, @shilman and @ndelangen! |
Issue: #8461
Pass the CLI
--quiet
option to the hot module replacement clientinstead of hardcoding it in development builds. A minor improvement to
60961d3 (#9535).
#8461 (comment)
What I did
Pass
--quiet
to webpack-hot-middleware/client. Default to true.How to test
Pass
--quiet
tostart-storybook
and HMR messages should disappear.If your answer is yes to any of these, please make sure to include it in your PR.