Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Deprecate setAddon from storiesOf API #11322

Merged
merged 2 commits into from Jun 26, 2020
Merged

Core: Deprecate setAddon from storiesOf API #11322

merged 2 commits into from Jun 26, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 26, 2020

Issue: #10008

What I did

Self-merging @tmeasday

How to test

  • Client-API tests pass
  • Added deprecated example

@shilman shilman added this to the 6.0 breaking milestone Jun 26, 2020
@github-actions
Copy link
Contributor

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against 75f03b1

tmeasday
tmeasday approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@shilman shilman merged commit da9acaa into next Jun 26, 2020
@shilman shilman mentioned this pull request Jun 26, 2020
Closed
@stof stof deleted the 10008-deprecate-setaddon branch May 25, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGE core preview-api
Projects
None yet
Milestone
6.0 breaking
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shilman @tmeasday