Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-Docs: Fix ArgsTable controls on Docs tab #11552

Merged
merged 1 commit into from Jul 15, 2020
Merged

Addon-Docs: Fix ArgsTable controls on Docs tab #11552

merged 1 commit into from Jul 15, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 15, 2020 •
edited

Issue: N/A

What I did

How to test

cd examples/official-storybook
yarn storybook
open http://localhost:9011/?path=/docs/addons-docs-props--controls

Edit args in both addon panel and Docs tab & story itself and verify that everything stays in sync

@shilman shilman requested a review from usulpro as a code owner July 15, 2020 04:49
@shilman shilman added this to the 6.0 args milestone Jul 15, 2020
@shilman shilman mentioned this pull request Jul 15, 2020
Merged
3 tasks
tmeasday
tmeasday approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shilman shilman merged commit 84e4692 into next Jul 15, 2020
@stof stof deleted the fix/docs-controls-events branch May 25, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
addon: controls addon: docs bug
Projects
None yet
Milestone
6.0 args
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shilman @tmeasday