Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Add argTypes to StoryContext #11558

Merged
merged 1 commit into from Jul 15, 2020
Merged

Core: Add argTypes to StoryContext #11558

merged 1 commit into from Jul 15, 2020

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jul 15, 2020 •
edited by shilman

Issue: #11555

We store argTypes on parameters but that's just a convenience.

What I did

Added argTypes to StoryContext

@tmeasday tmeasday requested a review from shilman July 15, 2020 11:22
@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against ae5fef0

@shilman shilman added core maintenance User-facing maintenance tasks labels Jul 15, 2020
@shilman shilman added this to the 6.0 args milestone Jul 15, 2020
@shilman shilman changed the title Add argTypes to StoryContext Core: Add argTypes to StoryContext Jul 15, 2020
@shilman shilman merged commit 64c3bf2 into next Jul 15, 2020
@shilman shilman mentioned this pull request Jul 15, 2020
Closed
@stof stof deleted the add-argTypes-to-context branch May 25, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@kazupon kazupon Awaiting requested review from kazupon

@ndelangen ndelangen Awaiting requested review from ndelangen

@theinterned theinterned Awaiting requested review from theinterned

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees
No one assigned
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.0 args
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmeasday @shilman