Add display configuration options to info addon #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
+ Coverage 13.7% 13.72% +0.02%
==========================================
Files 207 207
Lines 4647 4640 -7
Branches 518 511 -7
==========================================
Hits 637 637
- Misses 3546 3557 +11
+ Partials 464 446 -18
Continue to review full report at Codecov.
|
ndelangen
requested changes
May 30, 2017
| @@ -112,8 +113,14 @@ function previewProp(val) { | |||
|
|
|||
| export default class PropVal extends React.Component { | |||
| render() { | |||
| return previewProp(this.props.val); | |||
| return previewProp(this.props.val, this.context); | |||
There was a problem hiding this comment.
Can we do it without context ?
|
Hey @z4o4z can you fix the merge conflicts? sorry. |
|
@ndelangen Hi, of course) |
ndelangen
approved these changes
Jun 7, 2017
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1152
What I did
Add new options:
How to test
Run
npm run storybookto see new stories and test it!