Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX build on travis for node 8 #1172

Merged
merged 2 commits into from May 31, 2017
Merged

FIX build on travis for node 8 #1172

merged 2 commits into from May 31, 2017

Conversation

ndelangen
Copy link
Member

Issue: -travis CI failed when set on latest-

What I did

I fixed it

How to test

Have travis run succesfully

@codecov
Copy link

codecov bot commented May 31, 2017

Codecov Report

Merging #1172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1172   +/-   ##
=======================================
  Coverage   13.31%   13.31%           
=======================================
  Files         199      199           
  Lines        4589     4589           
  Branches      725      725           
=======================================
  Hits          611      611           
  Misses       3349     3349           
  Partials      629      629

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6cecd...6e36fae. Read the comment docs.

@ndelangen ndelangen added in progress maintenance User-facing maintenance tasks cleanup Minor cleanup style change that won't show up in release changelog and removed maintenance User-facing maintenance tasks labels May 31, 2017
@ndelangen ndelangen self-assigned this May 31, 2017
@ndelangen ndelangen requested a review from shilman May 31, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant