Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document preview entries in presets #11876

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Document preview entries in presets #11876

merged 2 commits into from
Aug 11, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 10, 2020

Issue: N/A

@shilman shilman added this to the 6.0 milestone Aug 10, 2020
@shilman shilman requested a review from tmeasday August 11, 2020 00:42
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from qn about snippet

Comment on lines 121 to 129
// defaultParameters.ts
export const parameters = {
backgrounds: {
values: [
{ name: 'light', value: '#F8F8F8' },
{ name: 'dark', value: '#333333' },
],
},
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a code snippet?

@shilman shilman merged commit e680f98 into next Aug 11, 2020
@stof stof deleted the docs/preview-entries branch May 25, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants