Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Updates for the code snippets #11878

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Conversation

jonniebigodes
Copy link
Contributor

This pull request addresses some of the feedback for the documentation:

What was done:

  • The json/shell snippets are removed and their content is now shown in the markdown file.
  • The writing docs snippets, the mdx examples are updated.

Feel free to provide feedback.

Updates for the writing docs section
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's move a couple comments

docs/snippets/common/badge-story.mdx.mdx Outdated Show resolved Hide resolved
docs/snippets/common/checkbox-story.mdx.mdx Outdated Show resolved Hide resolved
docs/snippets/common/mdx-canvas-multiple-stories.mdx.mdx Outdated Show resolved Hide resolved
@shilman shilman merged commit 1a8351e into next Aug 11, 2020
@stof stof deleted the documentation_snippets_updates branch May 25, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants