Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Documentation for stories.json #12510

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

jonniebigodes
Copy link
Contributor

This pull request addresses the following discussion #12336 .

What was done:

  • Updated the docs/workflows/storybook-composition.md file with additional context regarding the topic at hand.
  • Created a example snippet to demonstrate the contents of stories.json file that is generated with sb extract

@ndelangen let me know if you're ok with the wording and flow so that we close the discussion.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Sep 17, 2020
@ndelangen
Copy link
Member

looks great

@jonniebigodes
Copy link
Contributor Author

@ndelangen thank you for taking a look at it. Going to merge it now. Should any updates are in order, we can always make a follow up pull request and fine tune the docs.

@jonniebigodes jonniebigodes merged commit 1aa1257 into next Sep 23, 2020
@jonniebigodes jonniebigodes deleted the chore_add_docs_for_discussion_12336 branch September 23, 2020 22:11
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 26, 2020
shilman pushed a commit that referenced this pull request Sep 26, 2020
…ion_12336

Chore: Documentation for stories.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants