Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add option to include story names when sorting #12520

Merged
merged 5 commits into from
Apr 30, 2021

Conversation

diedu89
Copy link
Contributor

@diedu89 diedu89 commented Sep 19, 2020

Issue: #12512

What I did

Add option in storySort configuration object to include story names when sorting.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@diedu89 diedu89 changed the title feat: add option to include story names when sorting feat: add option to include story names when sorting [feature request] Sep 19, 2020
@diedu89 diedu89 changed the title feat: add option to include story names when sorting [feature request] feat: add option to include story names when sorting Sep 19, 2020
@shilman shilman added this to the 6.1 maintenance milestone Sep 24, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@stale stale bot removed the inactive label Jan 2, 2021
@shilman shilman removed this from the 6.2 maintenance milestone Apr 1, 2021
@jonniebigodes
Copy link
Contributor

@shilman can you take a look at this one on your end? Documentation wise looks good on me.

@shilman shilman changed the title feat: add option to include story names when sorting Core: Add option to include story names when sorting Apr 30, 2021
@nx-cloud
Copy link

nx-cloud bot commented Apr 30, 2021

Nx Cloud Report

CI ran the following commands for commit b8592f7. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @diedu89 !! Made some small tweaks before merging 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants