Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Tighten preset webpack pattern for mdx stories #13476

Merged
merged 1 commit into from Dec 19, 2020

Conversation

wKich
Copy link
Member

@wKich wKich commented Dec 18, 2020

Issue: Slightly incorrect regexp for mdx stories

What I did

Escaped dot symbol in regexp

@wKich
Copy link
Member Author

wKich commented Dec 18, 2020

@shilman, please, take a look

@shilman shilman added addon: docs bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 19, 2020
@shilman shilman added this to the 6.1.x milestone Dec 19, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wKich!! 🙏

@shilman shilman changed the title fix: preset webpack test regexp for mdx stories Addon-docs: Tighten preset webpack test regexp for mdx stories Dec 19, 2020
@shilman shilman changed the title Addon-docs: Tighten preset webpack test regexp for mdx stories Addon-docs: Tighten preset webpack pattern for mdx stories Dec 19, 2020
@shilman shilman merged commit 7e225e9 into storybookjs:next Dec 19, 2020
@wKich wKich deleted the fix/mdx-webpack-regexp branch December 30, 2020 06:29
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 12, 2021
shilman added a commit that referenced this pull request Jan 12, 2021
Addon-docs: Tighten preset webpack pattern for mdx stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants