Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Protect core metadata from decorators #13512

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Core: Protect core metadata from decorators #13512

merged 3 commits into from
Apr 30, 2021

Conversation

dominictwlee
Copy link
Contributor

@dominictwlee dominictwlee commented Dec 23, 2020 •
edited

Issue: #12737

What I did

Disallow users from overriding core metadata in story context.

How to test

  • Is this testable with Jest or Chromatic screenshots? yes
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

shilman
shilman approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@shilman shilman added core maintenance User-facing maintenance tasks labels Dec 24, 2020
@shilman shilman changed the title Decorators: protect core metadata Core: Protect core metadata from decorators Apr 29, 2021
@nx-cloud
Copy link

nx-cloud bot commented Apr 29, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit f4dcaca. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman
Copy link
Member

shilman commented Apr 29, 2021

somehow this never got merged 🙈

@shilman shilman merged commit ec3b09b into storybookjs:next Apr 30, 2021
@shilman shilman mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dominictwlee @shilman