CLI: fix sb init prompt when framework type is undetected #13520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
requested review from
igor-dv,
shilman and
stijnkoopal
as code owners
|
@shilman @ndelangen after the work done in #13013 I believe the CLI can't install Storybook in typescript projects anymore. Would any of you care to help? Maybe the fix would suit in this PR? The ESM/CJS build result won't contain the typescript files from the templates. When running What I mean by copying an empty folder you can see with the result of the esm build in the cli project:
|
gaetanmaisse
force-pushed
the
fix/sb-cli-prompt
branch
from
b3c8697
to
b902594
Compare
|
@gaetanmaisse you're the best ❤️ |
I inverted the logic to check if we are in the SB CLI package as this is the only package that require extra check on filenames.
gaetanmaisse
force-pushed
the
fix/sb-cli-prompt
branch
from
b902594
to
c4ba07c
Compare
gaetanmaisse
reviewed
Jan 5, 2021
Signed-off-by: Gaëtan Maisse <gaetanmaisse@gmail.com>
gaetanmaisse
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When inquirer was replaced with prompts in #13226,
sb inithad a bug that wouldn't display a list of installable projects when no framework was detected.What I did
Set the correct prompt type in the prompt function.
Result of
sb initin @next:Result of
sb initwith this PR:How to test
1 -
yarn build cli1 - create a folder with just a package.json like with
npm init2 - run
node ../../storybook/lib/cli/dist/esm/generate init(adjust the path to where you folder will be)