Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 Updated link to point to the correct place #1373

Merged
merged 1 commit into from
Jun 28, 2017
Merged

馃摑 Updated link to point to the correct place #1373

merged 1 commit into from
Jun 28, 2017

Conversation

ummahusla
Copy link
Contributor

@ummahusla ummahusla commented Jun 28, 2017

I updated Writing stories link which was pointing to https://storybook.js.org/basics/slow-start-guide/ instead of https://storybook.js.org/basics/writing-stories/

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@shilman shilman merged commit cfa20f9 into storybookjs:master Jun 28, 2017
@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Jun 28, 2017
@codecov
Copy link

codecov bot commented Jun 28, 2017

Codecov Report

Merging #1373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1373    +/-   ##
========================================
  Coverage   14.35%   14.35%            
========================================
  Files         201      201            
  Lines        4613     4613            
  Branches      624      506   -118     
========================================
  Hits          662      662            
- Misses       3427     3512    +85     
+ Partials      524      439    -85
Impacted Files Coverage 螖
addons/info/src/components/markdown/htags.js 0% <0%> (酶) 猬嗭笍
app/react/src/server/build.js 0% <0%> (酶) 猬嗭笍
lib/ui/src/libs/key_events.js 23.25% <0%> (酶) 猬嗭笍
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (酶) 猬嗭笍
app/react/src/server/babel_config.js 44.82% <0%> (酶) 猬嗭笍
app/react-native/src/bin/storybook-start.js 0% <0%> (酶) 猬嗭笍
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (酶) 猬嗭笍
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (酶) 猬嗭笍
addons/knobs/src/KnobStore.js 6.81% <0%> (酶) 猬嗭笍
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (酶) 猬嗭笍
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dbd6842...0585290. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants