Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(CONTRIBUTING): suggest using next in forks #13968

Merged
merged 1 commit into from
Feb 20, 2021
Merged

docs(CONTRIBUTING): suggest using next in forks #13968

merged 1 commit into from
Feb 20, 2021

Conversation

oscard0m
Copy link
Contributor

@oscard0m oscard0m commented Feb 20, 2021 •
edited

Issue: #13967

What I did

Modify CONTRIBUTING.md suggesting users working on their fork to use next as base branch

How to test

  • Is this testable with Jest or Chromatic screenshots? ❌
  • Does this need a new example in the kitchen sink apps? ❌
  • Does this need an update to the documentation? ❌

@oscard0m
docs(CONTRIBUTING): suggest using next in forks
7c4a26b 
users working on their fork should use `next` as base branch
shilman
shilman approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 thank you!

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 20, 2021
@shilman shilman merged commit 222abe4 into storybookjs:next Feb 20, 2021
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 22, 2021
shilman added a commit that referenced this pull request Feb 22, 2021
@shilman
Merge pull request #13968 from oscard0m/patch-1
4f83e49 
docs(CONTRIBUTING): suggest using `next` in forks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscard0m @shilman