Yarn PnP: Add missing dependencies for Webpack 4/5 work #13992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
shilman
reviewed
Feb 21, 2021
addons/docs/package.json
Outdated
| @@ -60,6 +60,7 @@ | |||
| "@mdx-js/react": "^1.6.22", | |||
| "@storybook/addons": "6.2.0-alpha.32", | |||
| "@storybook/api": "6.2.0-alpha.32", | |||
| "@storybook/builder-webpack4": "^6.2.0-alpha.32", | |||
There was a problem hiding this comment.
@gaetanmaisse Why do we need this?
There was a problem hiding this comment.
Because of this line:
lib/core-server/package.json
Outdated
| "@babel/preset-react": "^7.12.10", | ||
| "@storybook/addons": "6.2.0-alpha.32", | ||
| "@storybook/builder-webpack4": "6.2.0-alpha.32", | ||
| "@storybook/core-client": "6.2.0-alpha.32", |
There was a problem hiding this comment.
As it's used as a default value in
I ran the PnP E2E test locally: yarn bootstrap --core
yarn local-registry --port 6000 --open --publish
# In another terminal
yarn test:e2e-framework --use-yarn-2-pnp --use-local-sb-cli cra
# To simplify the debug I also linked the SB packages to the monorepo to avoid to republish each time a change is made
# from the monorepo
cd ../storybook-e2e-testing/cra-latest
yarn link ../../storybook --allAnd then I fixed the |
shilman
changed the title
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added all the missing dependencies listed by Yarn 2 E2E tests.
How to test